Fix #1828: urlToAccounts returns converted data #1830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the regression happened in fe7c66e#diff-bc08808ad598b8a873b55b7fe24d4bd6b4159f3228b5f4ffc947bf3bbeca0604R572 here, note how we build
converted
but never return it 😭. Thefriendica.ts
has the correct return, just not Mastodon 😅Tested as follows (I may have skipped a step here, sorry, let me know and I'll elaborate this): first check out this branch of
megalodon
and build it via:(There's some weird version issue when run
npm i
, something about eslint being unsatisfied, so I use--force
to skip this…)Then make a test app and install this modified
megalodon
:and in here create
index.ts
:and build this and run it:
Should print out a number >40. (
45008
is me on Octodon, so you'll have to change this probably.)