Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions refactor #169

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Github Actions refactor #169

merged 5 commits into from
Nov 13, 2023

Conversation

h4570
Copy link
Owner

@h4570 h4570 commented Nov 13, 2023

  • Add "PR build check"
  • Add "Official build"
  • Small cosmetic changes

Based on #168 by @israpps

@israpps
Copy link
Contributor

israpps commented Nov 13, 2023

Why two workflows?

@h4570
Copy link
Owner Author

h4570 commented Nov 13, 2023

First for pull requests - to check if code is compilable.
Second for master - to build latest code after PR merge, so people can easily download latest binaries without compilation.

@h4570 h4570 merged commit fdc5450 into master Nov 13, 2023
3 checks passed
@h4570 h4570 deleted the github-actions branch November 13, 2023 18:27
@israpps
Copy link
Contributor

israpps commented Nov 13, 2023

First for pull requests - to check if code is compilable.
Second for master - to build latest code after PR merge, so people can easily download latest binaries without compilation.

In that case, make a single workflow, where binaries are publicly released only for the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants