Updated doctype case. Github Pages does not recognize lowercase doctype. #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowercase <!doctype html> declaration is not recognized by Github Pages. Changed to <!DOCTYPE html> to ensure compatibility.
The casing of a doctype is not something a website supports, but rather something the browser implements, so I’m confused by this statement. What do you mean? Ref. #1522. |
|
To be honest, I'm just as confused. Browsers don't discriminate, I agree. I published a site to Github Pages using the boilerplate and the root URL redirected me to a 404 page. After capitalizing and committing, it worked. Also, I apologize if this PR is premature or didn't follow community guidelines. |
|
The problem you were seeing was likely unrelated to the doctype casing. It takes some time for GitHub Pages to deploy after you push. My guess is you checked the page before it was fully deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowercase <!doctype html> declaration is not recognized by Github Pages. Changed to to ensure compatibility.
Types of changes
Checklist:
Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.
Thanks!