upgrade to gulp 4 and update others dev dependencies #2151
Conversation
|
That's great, thanks! I'll test this out. |
gulpfile.babel.js
Outdated
| dot: true | ||
|
|
||
| }).pipe(gulp.dest(dirs.dist)) | ||
| // Include hidden files by default |
There was a problem hiding this comment.
minor nitpick here - but the indentation is a little bit off. should be 4 spaces (not 6) on lines 124 and 125 and indent of 2 spaces on line 126.
|
great PR! Nice work @Symro. I've tested this on Windows 10 Pro and no issues. Builds fine with no errors and |
gulpfile.babel.js
Outdated
|
|
||
| gulp.task('default', ['build']); | ||
| gulp.task('default', gulp.series('build')) |
There was a problem hiding this comment.
eslint complains that this should have a semicolon at the end here.
|
This is really great. I tested with and it build with no problem.
Thanks for coming through so quickly on this. I am really happy we were able to get this fixed. |
You're welcome ;), I dit this kind of work a couple of months ago so it was really fun to do it again for an open source project 👍. |
Types of changes
Checklist:
Hi I saw your tweet and the issue #2150. I did the migration to Gulp 4. You can test by yourself to check if it's the intended behaviour. It should I did not change that much.
What I did exactly:
My node version: v10.15.4 and npm: 6.9.0. I don't know if the projects now works for "node": ">=8" and "npm": ">=3". Maybe we need to update the engine config aswell.
Cheers ! 🍻