Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README.md and CHANGELOG.md files #3064

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Yigaue
Copy link
Contributor

@Yigaue Yigaue commented Jan 12, 2024

The change involves correction in the following:
a closing parenthesis was omitted in changelog.md file and a misspelling was made in Readme.md file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

The change involves correction in the following:
a closing parenthesis was omitted in changelog.md file and a misspelling was made in Readme.md file.
@coliff coliff merged commit 4c3245a into h5bp:main Jan 12, 2024
6 checks passed
@coliff
Copy link
Member

coliff commented Jan 12, 2024

Thanks!

@Yigaue Yigaue deleted the readme-changelog branch January 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants