Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .stylelintrc #18

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Create .stylelintrc #18

merged 2 commits into from
Apr 12, 2019

Conversation

roblarsen
Copy link
Member

closes #17

This is just a copy and paste of the example. We can edit before pulling it in.

@roblarsen roblarsen added the WIP Work in progress label Mar 22, 2019
@roblarsen roblarsen self-assigned this Mar 22, 2019
@roblarsen roblarsen requested a review from coliff March 22, 2019 19:15
@roblarsen roblarsen changed the title Create .stylelintrc Create .stylelintrc WIP Mar 22, 2019
@coliff
Copy link
Member

coliff commented Mar 25, 2019

With this PR, if you open project in VS Code it'll give a error:
'stylelint: Could not find "stylelint-config-recommended"' - so we need to either to add that as a dev dependency to the package.json - or alternatively copy/paste the rules to the .stylelintrc. As the gulp script is needed to make a build anyway I think it makes more sense to add the stylelint-config-recommended as a devdep that way we can bring in any future improvements from that project without needing to re-copy and paste.

@coliff
Copy link
Member

coliff commented Mar 25, 2019

Once stylelint-config-recommended is installed it reports a number of formatting issues with our CSS. We should either fix the issues in the CSS or modify/remove the relevant rules from the .stylelintrc

@roblarsen
Copy link
Member Author

Yeah, i didn't even begin to look at the actual rules.

@coliff
Copy link
Member

coliff commented Mar 25, 2019

I added stylelint-config-recommended to package.json... removed the rules which reported errors which I didn't think were helpful in addressing. Shall I commit those changes to this branch - or would you rather have a look yourself?

@roblarsen
Copy link
Member Author

Just commit them and I'll take a look

- removed unneeded `-webkit-box-shadow: none !important;` from print styles. If it was needed it'd be added by autoprefixer.
- removed unneeded rules from `.stylelintrc`
@coliff
Copy link
Member

coliff commented Apr 12, 2019

@roblarsen - this PR says its awaiting my review, I'm all good for it to merged. :-)

@roblarsen
Copy link
Member Author

💪

@roblarsen roblarsen changed the title Create .stylelintrc WIP Create .stylelintrc Apr 12, 2019
@roblarsen roblarsen merged commit 92e6cdb into master Apr 12, 2019
@coliff coliff mentioned this pull request Apr 12, 2019
4 tasks
@coliff coliff deleted the stylelint branch April 15, 2019 15:07
@coliff coliff removed the WIP Work in progress label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Stylelint Config
2 participants