Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for suffix textOverflow #28

Open
sabifa opened this issue Sep 26, 2024 · 2 comments
Open

Add ability for suffix textOverflow #28

sabifa opened this issue Sep 26, 2024 · 2 comments

Comments

@sabifa
Copy link

sabifa commented Sep 26, 2024

Thanks for your package, I really like it so far.
One thing that is missing for my usecase is the ability to specify a textOverflow for the suffix (e.g. ellipsis).

I've created a PR that adds this functionality. What are your thoughts on this?

sabifa pushed a commit to sabifa/flutter-animated-counter that referenced this issue Sep 26, 2024
@sabifa
Copy link
Author

sabifa commented Sep 26, 2024

Another possibility would be to change the type of suffix / prefix to Widget instead of String. This way I could pass my adapted overflowable text widget into the widget like so instead of adding the suffixOverflow param.

AnimatedFlipCounter(
  duration: Duration(milliseconds: 500),
  value: _value,
  suffix: Flexible(
    child: Text(
      'my long text that is currently overflowing',
      overflow: TextOverflow.ellipsis,
    ),
  )
)

This would produce a breaking change though.

@Muhammarizo
Copy link

I have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants