perf: 代码逻辑优化 TencentBlueKing#87

hLinx · Aug 3, 2021 · ef42cf0 · ef42cf0
1 parent f868c8a
commit ef42cf0
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 19 deletions.
diff --git a/src/frontend/src/views/task-manage/common/render-global-var/index.vue b/src/frontend/src/views/task-manage/common/render-global-var/index.vue
@@ -359,10 +359,12 @@
                     confirmFn: () => {
                         const currentVar = this.variable[index];
                         if (currentVar.id > 0) {
-                            // 删除已存在的变量——设置delete
+                            // 删除已存在的变量
+                            //  —设置delete
                             currentVar.delete = 1;
                         } else {
-                            // 删除新建的变量——直接删除
+                            // 删除新建的变量
+                            //  —直接删除
                             this.variable.splice(index, 1);
                         }
                         this.triggerChange();

diff --git a/src/frontend/src/views/task-manage/common/render-global-var/operation/index.vue b/src/frontend/src/views/task-manage/common/render-global-var/operation/index.vue
@@ -75,9 +75,9 @@
         <component
             ref="handler"
             :is="globalVarCom"
-            :variable="variable"
             :data="formData"
-            @on-change="handleGetValue" />
+            v-bind="$attrs"
+            v-on="$listeners" />
     </jb-form>
 </template>
 <script>
@@ -99,12 +99,6 @@
             VarArray,
         },
         props: {
-            variable: {
-                type: Array,
-                default () {
-                    return [];
-                },
-            },
             data: {
                 type: Object,
                 default () {
@@ -138,12 +132,13 @@
         },
         watch: {
             data: {
-                handler  (data) {
+                handler (data) {
                     if (data.name) {
                         // 编辑变量
                         this.formData = data;
                     } else {
                         // 新建变量
+                        // 初始化默认值
                         this.formData = createVariable();
                     }
                     this.globalType = this.formData.typeDescription;
@@ -167,9 +162,6 @@
                     this.globalType = '';
                 });
             },
-            handleGetValue (payload) {
-                this.$emit('on-change', payload);
-            },
         },
     };
 </script>

diff --git a/src/frontend/src/views/task-manage/common/render-task-step/index.vue b/src/frontend/src/views/task-manage/common/render-task-step/index.vue
@@ -308,9 +308,6 @@
                 immediate: true,
             },
         },
-        created () {
-            this.innerChange = false;
-        },
         methods: {
             /**
              * @desc 外部调用——点击指定 index 的步骤
@@ -409,8 +406,12 @@
 
                         const currentStep = steps[index];
                         if (currentStep.id) {
+                            // 删除已存在的步骤
+                            //  —设置delete
                             currentStep.delete = 1;
                         } else {
+                            // 删除新建的步骤
+                            //  —直接删除
                             steps.splice(index, 1);
                         }
 
@@ -425,7 +426,6 @@
              * @param {Boolean} localValidator 表单验证结果
              */
             handleTaskStepSubmit (payload, localValidator) {
-                this.innerChange = true;
                 const operationStep = new TaskStepModel(payload);
                 const steps = [...this.steps];
 

diff --git a/src/frontend/src/views/task-manage/template-operation/index.vue b/src/frontend/src/views/task-manage/template-operation/index.vue
@@ -471,7 +471,7 @@
                             if (this.isEdit) {
                                 this.editSuccessCallback(taskId, planSync, isPlanEmpty);
                             } else {
-                                this.createSuccessCallback(taskId, planSync, isPlanEmpty);
+                                this.createSuccessCallback(taskId);
                             }
                         });
                     }))