Improve TypeScript config #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrades to the latest, major TypeScript version
- Removes the unused, extra types file
TSConfig:
- Updates `target` and `module` to modern
but Node.js 16 compatible values
- Removes the following options:
- `esModuleInterop` and `allowSyntheticDefaultImports`
(which have default values)
- `moduleResolution` (which conflicts with "module": "nodenext",
and whose default value is taken from `module`)
- `checkJs` (because there are no .js files, only .ts ones)
- `exclude` (because the listed directories are not inside `include`
and thus not included by default)
- Simplifies the `include` list to just use the source directory
valtlai
commented
Oct 2, 2023
valju
reviewed
Oct 2, 2023
|
How did the Knex people do, they have an update for this? Is this already final? When should we accept this? |
|
They have an update, yeah, but it’s not released yet. I don’t know when it will happen. Let’s merge this now, and I’ll open a new PR later once the new Knex version is available. |
valju
approved these changes
Oct 4, 2023
valtlai
added a commit
that referenced
this pull request
Oct 6, 2023
Removes the workaround introduced in #180.
Closed
valtlai
added a commit
that referenced
this pull request
Oct 6, 2023
Removes the workaround introduced in #180.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSConfig:
targetandmoduleto modern but Node.js 18 compatible valuesesModuleInteropandallowSyntheticDefaultImports(which have default values)moduleResolution(which conflicts with"module": "nodenext", and whose default value is taken frommodule)checkJs(because there are no .js files, only .ts ones)exclude(because the listed directories are not insideincludeand thus not included by default)includelist to use just the source directory