Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cut 0.2.0 release #129

Merged
merged 1 commit into from
Nov 20, 2017
Merged

*: cut 0.2.0 release #129

merged 1 commit into from
Nov 20, 2017

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Nov 20, 2017

This PR cuts the release: bumps the version and adds an entry for the new version in the changelog. Once merged, off of the latest commit on master a new branch called "release-0.2" and the "v0.2.0" tag is created. Both are then pushed to the upstream repository.

cc @asymmetric @nhlfr

CHANGELOG.md Outdated

## Features & Enhancements

- React on all events involved with a Habitat object to reconcile to the desired state, faster and more consistently [#113](https://github.com/kinvolk/habitat-operator/pull/113)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React on -> React to
reconcile to -> reconcile with

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: the wording sounds weird somehow. I'd say something like "for faster and more consistent reconciliation [to the desired state]".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"to" is wrong here. You either "reconcile X to Y" or "reconcile with X". Check the dictionary for examples. :)

Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about wording, looks fine otherwise.

CHANGELOG.md Outdated

## Features & Enhancements

- React on all events involved with a Habitat object to reconcile to the desired state, faster and more consistently [#113](https://github.com/kinvolk/habitat-operator/pull/113)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: the wording sounds weird somehow. I'd say something like "for faster and more consistent reconciliation [to the desired state]".

@lilic lilic merged commit 269a0d9 into master Nov 20, 2017
@lilic lilic deleted the lili/cut-0.2.0 branch November 20, 2017 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants