-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: cut 0.2.0 release #129
*: cut 0.2.0 release #129
Conversation
CHANGELOG.md
Outdated
|
||
## Features & Enhancements | ||
|
||
- React on all events involved with a Habitat object to reconcile to the desired state, faster and more consistently [#113](https://github.com/kinvolk/habitat-operator/pull/113) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React on -> React to
reconcile to -> reconcile with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: the wording sounds weird somehow. I'd say something like "for faster and more consistent reconciliation [to the desired state]".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"to" is wrong here. You either "reconcile X to Y" or "reconcile with X". Check the dictionary for examples. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit about wording, looks fine otherwise.
CHANGELOG.md
Outdated
|
||
## Features & Enhancements | ||
|
||
- React on all events involved with a Habitat object to reconcile to the desired state, faster and more consistently [#113](https://github.com/kinvolk/habitat-operator/pull/113) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: the wording sounds weird somehow. I'd say something like "for faster and more consistent reconciliation [to the desired state]".
4887bb1
to
3c149f3
Compare
This PR cuts the release: bumps the version and adds an entry for the new version in the changelog. Once merged, off of the latest commit on master a new branch called "release-0.2" and the "v0.2.0" tag is created. Both are then pushed to the upstream repository.
cc @asymmetric @nhlfr