CHANGELOG: Deprecate customVersion = v1beta1 #257
Conversation
asymmetric
force-pushed
the
asymmetric/deprecations-0.6
branch
2 times, most recently
from
bc29f3b
to
e42f1fb
Compare
CHANGELOG.md
Outdated
|
|
||
| * `Habitat` Manifests that do not specify a `customVersion`, or that specify a | ||
| `customVersion = v1beta1` are deprecated, and support for them will be removed | ||
| when Kubernetes 1.11 is released. Please upgrade your manifests by setting |
There was a problem hiding this comment.
I'm not sure I like the last sentence. Setting customVersion = v1beta2 is not enough. You need to use specv1beta2 field too. Maybe just drop this sentence or say something like "Please upgrade your manifests to the latest customVersion"?
|
I think it's good to mark it as deprecated now, even if we should've done it before.
How would you do that? Were you thinking of adding that to the README? |
asymmetric
force-pushed
the
asymmetric/deprecations-0.6
branch
from
e42f1fb
to
88a8697
Compare
Yep. Just a kind of a statement or a policy. |
We follow the release schedule of Kubernetes, according to which deprecated versions are dropped after 3 releases. `apps/v1beta2` was [introduced][v1beta2] in 1.8, thereby deprecating `v1beta1`, which should therefore be dropped by 1.11. `customVersion = v1beta1` maps to a controller that uses `apps/v1beta1`, which won't be updated, and that must therefore be droppped. [v1beta2]: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.8.md#workloads-api-appsv1beta2 Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
To `release-process.md`. Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
asymmetric
force-pushed
the
asymmetric/deprecations-0.6
branch
from
88a8697
to
96070b0
Compare
|
Added it to the design doc. |
|
LFAD. Could you add the deprecation notice here too? https://github.com/habitat-sh/habitat-operator/releases/tag/v0.6.0 |
We follow the release schedule of Kubernetes, according to which
deprecated versions are dropped after 3 releases.
v1beta2was introduced in 1.8, thereby deprecatingv1beta1, whichshould therefore be dropped by 1.11.
customVersion = v1beta1maps to a controller that usesapps/v1beta1,which won't be updated, and that must therefore be droppped.
Signed-off-by: Lorenzo Manacorda lorenzo@kinvolk.io