Remove dependency on pflag library #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asymmetric
force-pushed
the
asymmetric/remove-pflag
branch
from
2ffe3ae
to
e655e11
Compare
added 2 commits
May 9, 2018 17:15
The only advantage was that it allowed us to define a shorthand (`-v`) for the `--verbose` option, but we barely used that flag anyway, so the additional overhead wasn't worth it. Closes habitat-sh#78. Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
Actually nothing to update, just the input digest. Signed-off-by: Lorenzo Manacorda <lorenzo@kinvolk.io>
asymmetric
force-pushed
the
asymmetric/remove-pflag
branch
from
e655e11
to
e290110
Compare
|
Should this close #170 too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only advantage was that it allowed us to define a shorthand (
-v)for the
--verboseoption, but we barely used that flag anyway, so theadditional overhead wasn't worth it.
Closes #78.
Supersedes and closes #170.
Signed-off-by: Lorenzo Manacorda lorenzo@kinvolk.io