Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: print custom version string instead of pointer #275

Merged
merged 1 commit into from
May 14, 2018
Merged

controller: print custom version string instead of pointer #275

merged 1 commit into from
May 14, 2018

Conversation

iaguis
Copy link
Contributor

@iaguis iaguis commented May 14, 2018

Otherwise the error message will include a memory address which is not
very useful.

@iaguis
controller: print custom version string instead of pointer
9911818 
Otherwise the error message will include a memory address which is not
very useful.
@iaguis iaguis added the bug label May 14, 2018
@iaguis iaguis requested a review from asymmetric May 14, 2018 13:22
asymmetric
asymmetric approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're supposed to go check the memory address yourself, DUH!

LGTM.

@iaguis
Copy link
Contributor Author

iaguis commented May 14, 2018

You're supposed to go check the memory address yourself, DUH!

We can implement a --hard-mode flag to go back to the previous behavior :D

@iaguis iaguis merged commit e2d3c7d into habitat-sh:master May 14, 2018
@asymmetric asymmetric deleted the iaguis/fix-error-msg branch May 14, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asymmetric asymmetric asymmetric approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iaguis @asymmetric