-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hab pkg bulkupload origin creation option #7133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits, but otherwise looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @markan , I'd suggest making the "create origins" prompt for "yes/no/quit" part of the bulk upload flow by default so that users don't need to specify the --create-origins
flag.
If users would like the missing origins created automatically without the prompt, they can use the --auto-create-origins
flag to create the origins without the user confirmation.
The flow would look like this in the "future" branch:
Some nitpicks for the UX in the terminal. The goal is to keep the confirmation message consistent with what's in the GUI. Would love to hear @kagarmoe 's thoughts on it as well!
|
@apriofrost I've addressed your feedback wrt utilizing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code structure suggestion is optional, feel free to take it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback, otherwise looks great
…oad` subcommand Signed-off-by: Jeremy J. Miller <jm@chef.io>
d13255c
to
33b7be3
Compare
Closes #7101
UX ⚙️
Signed-off-by: Jeremy J. Miller jm@chef.io