Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-23022: Define the static variable __DEV__ #163

Merged
merged 1 commit into from
Aug 2, 2021
Merged

APP-23022: Define the static variable __DEV__ #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions webpack/overrides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
const { merge, remove } = require('lodash')
const webpack = require('webpack')

const helpers = require('../helpers')
const customConfig = require('./webpack.config')

module.exports = (defaultConfig) => {
let config = merge({}, defaultConfig, customConfig)

config.plugins.unshift(new webpack.DefinePlugin({
__DEV__: JSON.stringify(process.env.NODE_ENV !== "production"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to stringify a Boolean ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I copy-pasted it 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint: I never use double quotes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this results in a string instead of boolean 🤔 Weird...

}))

if (helpers.exists(
'circular-dependency-plugin',
'install the package to enable circular dependencies detection.'
Expand Down