Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend CORS functionality #25

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Extend CORS functionality #25

merged 1 commit into from
Jun 11, 2019

Conversation

icidasset
Copy link
Contributor

@icidasset icidasset commented Jun 10, 2019 •
edited
Loading

Hi 👋
This extends the CORS configuration and improves it a bit.

Changes:

  • The cors property is now an object/map (I don't see any reason to have this as a list)
  • allowed_hosts now accepts a list, instead of a string
  • You can set the allowed headers, allowed methods and exposed headers as well
  • Added a credentials setting (see README change for more info)

Thanks for the previous work on this @marcio199226 and @hacdias 🙌

hacdias
hacdias approved these changes Jun 11, 2019
View reviewed changes
Copy link
Owner

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll release this as 2.0.0 as it contains a breaking change.

@hacdias hacdias merged commit 7358553 into hacdias:master Jun 11, 2019
@icidasset
Copy link
Contributor Author

Thanks! ☺️

@icidasset icidasset deleted the extend-cors branch June 11, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icidasset @hacdias