Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for unix sockets #58

Merged
merged 1 commit into from
Dec 17, 2020
Merged

feat: add support for unix sockets #58

merged 1 commit into from
Dec 17, 2020

Conversation

mikitsu
Copy link
Contributor

@mikitsu mikitsu commented Dec 10, 2020

Allow a Unix socket to be specified as address in the configuration in the form of unix:/path/to/sock. The port setting is ignored in this case.

@mikitsu
Copy link
Contributor Author

mikitsu commented Dec 17, 2020

@hacdias ping

hacdias
hacdias approved these changes Dec 17, 2020
View reviewed changes
Copy link
Owner

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@hacdias hacdias changed the title add support for unix sockets feat: add support for unix sockets Dec 17, 2020
@hacdias hacdias merged commit fca4e54 into hacdias:master Dec 17, 2020
@mikitsu mikitsu deleted the unix-sockets branch December 18, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikitsu @hacdias