feat: add a config option to bypass mime content type sniffing #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
approved these changes
Jan 14, 2021
|
Thank you! Im going to release this as a major version, alongside with the other changes I just merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option,
nosniff, which allows the user to bypass mime sniffing.The reasoning behind adding this is the 512 byte read at the start of every file can be quite expensive in large and/or networked filesystems. Many users might prefer that mime sniffing be on, and disabling it entirely would be a possibly breaking change so it will remain that way by default.
Let me know if anything in this PR needs changing, and thank you for this project!