Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the fw API #25

Merged
merged 9 commits into from
Oct 15, 2019
Merged

Conversation

foreign-sub
Copy link

Add:
create_port_forwarding_configuration
delete_port_forwarding_configuration
edit_incoming_port_configuration
get_dmz_configuration
get_incoming_ports_configuration
get_port_forwarding_configuration
set_dmz_configuration

@stilllman stilllman merged commit 6baf1ba into hacf-fr:aiofreepybox Oct 15, 2019
@stilllman
Copy link

Thanks!

@foreign-sub foreign-sub deleted the add-fw branch October 15, 2019 22:31
@SNoof85
Copy link
Member

SNoof85 commented Oct 16, 2019

Sorry here, i'm late.

Is this not same part like NAT API ?
Some options more for sure but some are now twice in the package.

@SNoof85
Copy link
Member

SNoof85 commented Oct 16, 2019

I can say that we can delete the NAT because everything from NAT is covered here and not used in Home Assistant.
That will make a breaking change for any other program using aiofreepybox.

@SNoof85
Copy link
Member

SNoof85 commented Oct 16, 2019

#49 deletes NAT API

@foreign-sub
Copy link
Author

Is this not same part like NAT API ?

yes it is/was

@oncleben31 oncleben31 added the enhancement New feature or request label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants