Factorize common tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are now 68 tests vs 59 previously. |
tetienne
commented
Dec 18, 2020
| @@ -83,3 +83,6 @@ desktop.ini | |||
|
|
|||
| # Virtual env | |||
| .venv | |||
|
|
|||
| node_modules | |||
| package-lock.json | |||
tetienne
commented
Dec 18, 2020
| assert dsm._device_token is None | ||
|
|
||
| @pytest.mark.parametrize("version", [5, 6]) | ||
| def test_connection_failed(self, version): |
There was a problem hiding this comment.
Can be split later in several tests.
oncleben31
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of tests were duplicated between DSM 5 and 6. And some were added for DSM 6 but not for DSM 5.
I have regrouped the common test in a single class. Some remaining ones depend on the mocked hardware but use the same logic. I will with another PR to factorize them too.