fix: js.Wrapper was removed in go1.19 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes build against go1.19 js.Wrapper was removed: add it back as JSWrapper. golang/go#50310 golang/go@6c0daa7#diff-38b359833111770b96ea3bb8bc5e2b807e18bdbb80684a397ce63ff05e6d02ecL31 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to paralin/hackpad
that referenced
this pull request
Aug 10, 2022
Marked RFC until these are merged: - https://github.com/paralin/go/tree/hackpad/release-branch.go1.19 - hack-pad/hackpadfs#20 Fixes hack-pad#25 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to paralin/hackpad
that referenced
this pull request
Aug 10, 2022
Marked RFC until these are merged: - https://github.com/paralin/go/tree/hackpad/release-branch.go1.19 - hack-pad/hackpadfs#20 Fixes hack-pad#25 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to paralin/hackpad
that referenced
this pull request
Aug 10, 2022
Marked RFC until these are merged: - https://github.com/paralin/go/tree/hackpad/release-branch.go1.19 - hack-pad/hackpadfs#20 Fixes hack-pad#25 Signed-off-by: Christian Stewart <christian@paral.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build against go1.19
js.Wrapper was removed: add it back as JSWrapper.
golang/go#50310
golang/go@6c0daa7#diff-38b359833111770b96ea3bb8bc5e2b807e18bdbb80684a397ce63ff05e6d02ecL31