Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved timeline before venue in navbar #20

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

Sharjeel-Afridi
Copy link
Contributor

as timeline div is above venue then it should also be before venue in navbar.
(accept pr in hacktoberfest)

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
s3-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 8:29am

@Sharjeel-Afridi
Copy link
Contributor Author

Screenshot 2023-10-23 at 11 12 07 AM

here is a screenshot for reference
Screenshot 2023-10-23 at 11 13 22 AM

@imanishbarnwal
Copy link
Member

Hi @Sharjeel-Afridi thanks, can you please comment out the venue section from the Nav bar and website? We don't need that part for now.

@tamalCodes
Copy link
Member

@Sharjeel-Afridi Please mention the issue that was assigned to you in this format: closes #(issuenumber here like #11)

@Sharjeel-Afridi
Copy link
Contributor Author

Hi @Sharjeel-Afridi thanks, can you please comment out the venue section from the Nav bar and website? We don't need that part for now.

yes, should i close this PR and make another PR with the venue section commented out?

@Sharjeel-Afridi
Copy link
Contributor Author

@Sharjeel-Afridi Please mention the issue that was assigned to you in this format: closes #(issuenumber here like #11)

actually, i did not raise an issue and neither was i assigned any issue. I just made the changes and opened a PR.

@imanishbarnwal
Copy link
Member

Please comment out these sections as well

image

@imanishbarnwal
Copy link
Member

I guess you missed the live button on nav bar to comment... also do pull before pushing hero section has been changed a bit

@imanishbarnwal imanishbarnwal merged commit d886dae into hack4bengal:main Oct 25, 2023
2 checks passed
@imanishbarnwal
Copy link
Member

Great work bro!!

@Sharjeel-Afridi Sharjeel-Afridi deleted the changeinnavbar branch October 25, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants