Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grey background #26

Closed
wants to merge 2 commits into from

Conversation

geekayush
Copy link

Fixes #20

Changes: Add gradient background and box-shadow to navbar to make the contents visible even on lighter backgrounds.

Screenshot from 2019-08-23 15-26-26

@mooocer
Copy link
Member

mooocer commented Aug 23, 2019

Thanks for opening the pull request @geekayush! But, I was talking about this type of gradient. It will look better and give continuity to the site. Can you please change it to that instead?

@geekayush
Copy link
Author

I have changed it to the one shown below
Screenshot from 2019-08-23 17-56-15
P.S. Setting a lesser opaque background on the 'navbar' would seem changing colors because of the carousel backgrounds.

@mooocer
Copy link
Member

mooocer commented Aug 23, 2019

@geekayush But this looks completely opaque.
We need it to be shadowed around the corners. With the distance from the top, visibility of the shadow should decrease.
Something like this blog: https://css-tricks.com/snippets/css/top-shadow/, similar shadow but larger height.

@stale
Copy link

stale bot commented Sep 4, 2019

Because of no activity, this pull request is being marked as stale. Please clarify the status. If you no longer plan to work on it, kindly close the PR and let everyone know on the respective issue. It will be automatically closed if inactivity continues.

@stale stale bot added the stale label Sep 4, 2019
@stale
Copy link

stale bot commented Sep 5, 2019

Closing this PR because it has been stale for 7 days.

@stale stale bot closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation bar contents not visible
2 participants