Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support library Cabal >= 3.7 #45

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Support library Cabal >= 3.7 #45

merged 2 commits into from
Jun 13, 2022

Conversation

andreasabel
Copy link
Member

Deal with new testGenerators field of TestSuite stanza in a conservative way: do not allow changes in revision. See:

@andreasabel andreasabel added the re: cabal-version Support different `cabal-version`s properly label Jun 13, 2022
@andreasabel andreasabel added this to the 0.1.0.0 milestone Jun 13, 2022
@andreasabel andreasabel linked an issue Jun 13, 2022 that may be closed by this pull request
2 tasks
@andreasabel andreasabel force-pushed the cabal-3.7 branch 2 times, most recently from 1285acf to 4c817d1 Compare June 13, 2022 19:22
Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! :)

I'm very happy to hear about these new test-generators BTW!

@andreasabel
Copy link
Member Author

I'm very happy to hear about these new test-generators BTW!

You have to thank @gbaz for them! Gershom, do you have an opinion about revisability of test-generators?

@andreasabel andreasabel requested a review from gbaz June 13, 2022 20:12
@gbaz
Copy link

gbaz commented Jun 13, 2022

I don't think a revision of code-generators is at all meaningful. If a package isn't written to use a specific code-generator, adding the field won't be meaningful. And if it is written to do so, then altering the field isn't particularly meaningful. The versions of the code-generators used are controlled by build-tools-depends which allows version range editing. So better to disallow revisions for now, and change our mind if there's an unexpected use in the future.

@andreasabel andreasabel merged commit 4c817d1 into master Jun 13, 2022
@andreasabel andreasabel deleted the cabal-3.7 branch June 13, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: cabal-version Support different `cabal-version`s properly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GHC 9.4 and Cabal-3.7
3 participants