Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScifiCityscape-Robert #999

Merged
merged 3 commits into from
Dec 25, 2024
Merged

ScifiCityscape-Robert #999

merged 3 commits into from
Dec 25, 2024

Conversation

RobertoEchCCHS
Copy link
Contributor

Write a short description about your art piece, such as what your artwork represents and your experience drawing it!

Next, make sure you go through each item in the following checklist. Delete this line after!

  • I have read the steps to getting a blot
  • I have read all the submission requirements and follow them
  • I am submitting art that...
    • is algorithmically generated (will meaningfully change each time the program is run)
    • is your own work that is not copied from somewhere else
    • is drawable through the editor(does not use outside tools)
    • doesn't call Math.random() (See the documentation on randomness)
    • is drawable on Blot itself (doesn't have lines overlap more than 5 times)
      • Doesn't overlap lines more than 5 times
      • Fits in the working area of 125x125mm
      • Doesn't rely on colour to look good

The hardest part of this project was getting the line spacing just right to avoid too much overlap, while still keeping the design looking architectural. I learned how to balance the level of detail with the technical limits of the plotter by using things like different window patterns and careful spacing. This helped me add depth without making the plotter struggle.

Lastly, link a picture of your art piece here:
0

Copy link

vercel bot commented Nov 14, 2024

@RobertoEchCCHS is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Nov 14, 2024

art/ScifiCityscape-Robert/index.js looks like art! preview it in the editor

@RobertoEchCCHS
Copy link
Contributor Author

RobertoEchCCHS commented Nov 14, 2024

Please review the more recent one (Nov 13th), as the older one has errors!

@EnterpriseGoose
Copy link
Contributor

This is super cool! I think you could work on it a teeny bit more and then it would be perfect as a blot submission.
Here are some of my ideas:

  • The windows currently look like they're almost in the back of the building rather than the front. Mostly this is because they generate according to the back building rectangle and are behind the front building lines (see image below for an example). Would you be able to make the windows appear to generate on the front of the buildings?
    image
  • The geometric shapes in the sky are interesting but don't really add to the scenery. Could you figure out a replacement that would go with the buildings? Maybe make some clouds or a sun or some kind of other nice sky decoration?
  • Maybe you could add a bit more variation to the windows to make them seem more varied

Overall I can see you put a bunch of work into this, so it's just a few small details and then I think it'll be blot-worthy!

@RobertoEchCCHS
Copy link
Contributor Author

I'll update this soon, gonna take a while, I was also wondering... how do I update the code? Create a new PR?? Ty!

@EnterpriseGoose
Copy link
Contributor

EnterpriseGoose commented Nov 16, 2024 via email

@RobertoEchCCHS
Copy link
Contributor Author

I just updated it, it took a while to figure out how to put the windows randomly and in the front! I also added some abstract clouds! Thank you so much for your patience, I hope to get a blot soon!

@saumilthecode
Copy link
Contributor

woah really cool drawing!

but some area for improvements could be that the bottom part and the sky looks really blank right now!

(i dont review this officialy but this doesn't look like it meets the weird 30h in to get blot criteria so you might want to fix this)

@RobertoEchCCHS
Copy link
Contributor Author

I just updated my stuff with the previous reviewer's fixes, please let me know if I can finally get a blot machine after 40 hours of work! Thank you!

@saumilthecode
Copy link
Contributor

image
https://cloud-hnscao2gx-hack-club-bot.vercel.app/0image.png
(slack cdn cause the image is greater then 10mb somehow)

looks great though!
(for the "real" reviewer)

@qcoral
Copy link
Member

qcoral commented Dec 25, 2024

hi!! sorry for the long wait - this looks awesome and you can order a blot here:

https://airtable.com/appv0BzBY2APyIXj6/shrhpWVXN5imMzUmw

@qcoral qcoral merged commit c5838a2 into hackclub:main Dec 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants