-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm before deletion of project #742
Conversation
@Spectralo is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Try it out on the preview build! https://high-seas-idhtpmxoh.hackclub.dev/shipyard. Make sure to use a new test project, because the confirm didn't work for me and just immediately deleted the project. |
strange ... it shows the dialog but closes instantly |
@maxwofford i fixed smth in my code, should work now, can you approve the deployment ? |
thanks! oh wait, that check succeeded. Ignore me! |
@Spectralo I just tested the latest version and it still seems to close the dialog instantly. Seems like clicking delete ship also somehow triggers the save button? |
really ? strange ? checking that real quick |
auth doesnt work :/ |
@Spectralo added! try now |
Hey! Thank you sm for your help - I fixed the issues and realised that we don't actually use the shadcn dialogue component anywhere, #757 uses |
#718