Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm before deletion of project #742

Closed
wants to merge 3 commits into from
Closed

Conversation

Spectralo
Copy link

Copy link

vercel bot commented Nov 13, 2024

@Spectralo is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 7:42pm

@maxwofford
Copy link
Member

Try it out on the preview build! https://high-seas-idhtpmxoh.hackclub.dev/shipyard. Make sure to use a new test project, because the confirm didn't work for me and just immediately deleted the project.

@Spectralo
Copy link
Author

strange ... it shows the dialog but closes instantly

@Spectralo
Copy link
Author

@maxwofford i fixed smth in my code, should work now, can you approve the deployment ?

@polytroper polytroper changed the title This should fix it ? Confirm before deletion of project Nov 13, 2024
@polytroper
Copy link
Collaborator

polytroper commented Nov 13, 2024

@Spectralo make sure you are using prettier. Install the extension and then format all the files you have changed. We are enforcing style consistency now that there are so many more people contributing

thanks!

oh wait, that check succeeded. Ignore me!

@polytroper
Copy link
Collaborator

@Spectralo I just tested the latest version and it still seems to close the dialog instantly. Seems like clicking delete ship also somehow triggers the save button?

@Spectralo
Copy link
Author

really ? strange ? checking that real quick

@Spectralo
Copy link
Author

auth doesnt work :/

@Spectralo
Copy link
Author

image

@maxwofford
Copy link
Member

@Spectralo added! try now

@malted malted mentioned this pull request Nov 13, 2024
@malted
Copy link
Member

malted commented Nov 13, 2024

Hey! Thank you sm for your help - I fixed the issues and realised that we don't actually use the shadcn dialogue component anywhere, #757 uses components/ui/modal instead of it.

@malted malted closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants