Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kokonico to members.json #161

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Add Kokonico to members.json #161

merged 1 commit into from
Jul 12, 2024

Conversation

Kokonico
Copy link
Contributor

@Kokonico Kokonico commented Mar 1, 2024

I would like to be added to the hack club web ring, you can verify I'm in the slack by looking for @Kokonico (or KKNC) within it.

Copy link
Contributor

@kirby-b kirby-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have write access as far as I am aware, but this looks good.

@Shrey-Mehra
Copy link
Collaborator

Hey @Kokonico , did you add the HTML code to your site as I am looking on your site so webring isn't present anywhere

@Kokonico
Copy link
Contributor Author

Oh sorry! Didn't see your comment. I'll add the code to the website in a few hours.

@Shrey-Mehra
Copy link
Collaborator

Hey @Kokonico , will Wait till today for changes

@Kokonico
Copy link
Contributor Author

hello, I have added the changed to my website.

sorry it took so long! my footer code is weird, so I needed to inject the js after the badge 🫠

@Shrey-Mehra Shrey-Mehra self-requested a review July 12, 2024 04:57
Copy link
Collaborator

@Shrey-Mehra Shrey-Mehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool you have done from your End. I'm merging the pull request as everything looks fine to me

@Shrey-Mehra Shrey-Mehra merged commit 13ea204 into hackclub:main Jul 12, 2024
1 check passed
@Kokonico
Copy link
Contributor Author

I forgot to add a comma in the members.json file 😭, can you fix that?

@Shrey-Mehra
Copy link
Collaborator

But your site is looking well to me

@Kokonico
Copy link
Contributor Author

It's not the site that's the problem. It's the actual file in this repository that I edited. I forgot to put a comma before putting my entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants