-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design System Updates: Search/Filter Modal #1600
Comments
Please add this to action items
|
Ticket Outline/Review Title:
Description/Details: (optional if needed)
Action Items:
Resource/links:
|
We'll need to update the last three action steps based on the dependency, as Dev is working to load multiple years of data. Unassigning @allisonjeon and @giraffe2003 for now! |
We are no longer limited to 30 days of data. However, we need to add another option to the date picker; below "3 Month Range," add "Custom Date Range." In addition, we need to add the double chevron to indicate the beginning of the data set. |
We'll be updating this ticket with the above instructions and will notify you once we do so! |
Based on our PM meeting on 5-30-24 and for the purposes of the demo, we will be limiting data to 30 days, to avoid slow loading times. This ticket has been updated with new instructions and is ready to be assigned. |
@allisonjeon @giraffe2003 hi all, for this ticket, I'm going to add an action item where part of the deliverable is to design the modal to look similar with the existing modal on the demo (other than what's being specifically changed to improve the modal of course). This is because the dev team is having confusion/trouble with distinguishing what's being handed off/changed when parts of the design do not look identical to what exists in the demo. Because our design system is a mess at the moment, sometimes the modal component being used in hand-offs doesn't look the same to what is already existing in the 311 site demo. The image below is what I screenshotted from the live site. If the modal for this ticket is being handed off and the only changes you want the dev team to make is the date range picker, then the rest of the design should look exact. If other parts are being intentionally changed, then no worries and that can be noted when everything is being handed off. Lmk if you have questions! (tagging @ryanfchase for visibility) |
@annaseulgi this is very helpful for the dev team, thank you for adding this as an action item. Agreed, if other parts change, we should note this on the ticket or in a comment |
Hi Angela, Please leave a comment with the following items:
|
Hi Ryan! ETA: 2 weeks? |
Hi Angela, Please leave a comment with the following items:
Thanks! |
Unassigned Angela who is no longer active with 311Data |
Hi @ryanfchase @bberhane for the last two checklist items (see below) - are these required before handing off the design to developers? Or is it something that can be implemented in another round of revisions to the search/filter modal?
The search/filter modal has been updated significantly to address these two original issues:
If possible, I was wondering if we could add the two checklist items to ticket #1818 and move forward with the following design: Please let me know, thank you! |
@allisonjeon yep, works for me. I've moved those two action items to #1818, and I will strike them off this ticket. Good thinking, thanks! |
@allisonjeon I've also modified this ticket's original post with a Please provide any relevant "Before Screenshots" and "After Screenshots", either in the original comment (in their designated areas), or you can paste them in a new comment and I can help you format the ticket for hand off. |
Hey @ryanfchase I've updated the original comment with the relevant "Before Screenshots" and "After Screenshots". Please let me know what else is needed for hand off. Thank you! |
This is looking good @allisonjeon -- I'll have the PM team review it tomorrow evening. I'll adjust the labels and status to reflect "In Review", thanks 😄 |
PMs have OK'ed this. G2G for dev |
Engineering issue made for the Search/Filter Modal design update here: #1868 |
Dependency
Overview
The design team needs to update the calendar picker to address the following issues identified by the research and product teams:
Action Items
add double chevron to date picker/calendar to indicate earliest date of data collectionRemove "Last 3 Months" from the date range dropdown and replace with "Custom Date Range"Hand Off Materials
Figma Section Name: Search/Filter Modal #1600 - Final
Before Screenshot
After Screenshot (Finalized)
Resources/Instructions
The text was updated successfully, but these errors were encountered: