DEV - Remove Pins from React Redux State

[traycn]

Overview

We need to relegate storage of SR request data to Mapbox, and remove it from React Redux, since it is redundant and does not serve any functional purpose

Action Items

Fix non-performant loop in MapContainer (LOC 114)

• Modify componentDidUpdate to remove comparison of pins in props. Instead, check to see if the selected NC has changed

Remove Pins from Redux

• Remove GET_PINS_SUCCESS and GET_PINS_FAILURE from the Data reducer
  • this requires removing getPinsSuccess and getPinsFailure from our Redux sagas
  • are we using the Sagas for anything? Nobody seems to know

Optional

• record performance print-statements (console logs), see performance ticket below

Resources

I had documented load times under various filter criteria on this ticket. We'll want to know if removing pins from Redux state will improve performance. See measurements in comments here:

• Spike: Data Loading Checklist for Engineers to document loading times under various conditions  #1716

[ryanfchase]

@traycn changing title:

• From: Fix application crashing after user submits multiple queries / large queries
• To: Remove Non-Performant Loop in Map Lifecycle Method

I think "fixing application crashing" may be addressed by #1890

[ryanfchase]

Changing title again. We can go further from just removing the non-performant loop and simply remove pins from redux completely.

[traycn]

Hey @efrenmarin45 !

Please leave a comment with the following items:

• updated ETA
• progress from last week
• Any blockers this week?
• availability for communications during the week

[efrenmarin45]

ETA	Blockers	Availability
2/9 latest	None	Monday, Wednesday and Friday this week

I would like to touch base with you @traycn when you get the chance about what I'm coming across and get your thoughts on my proposed solution before this weeks meeting if possible.

[ryanfchase]

Ticket Check In w/ leads about #1865

4:30pm - 5:30pm

Notes

• Turns out that saga is completely integral to how we do state management. Previously I thought sagas were unrelated, but that's because we hadn't properly done the research around react, redux and sagas.
• mapDispatchToProps()
  • components > Map > index.jsx, ~L500
• getXYZ()
  • redux > reducers > data.js

Action Items

• dev lead to create ER on turning moving to functional components

Resources

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*
• https://redux-saga.js.org/docs/basics/UsingSagaHelpers/

[efrenmarin45]

ETA 2/10

[ryanfchase]

This ticket appears to be unblocked. Moving back to in-progress.

[efrenmarin45]

@ryanfchase @traycn Replaced the pin check (which was not initializing) with a neighborhood council ID so the component will render when the NC has changed. I also tested the removal of the pin check and Sagas involving GET_PINS_SUCCESS and GET_PINS_FAILURE and posted the results in #1716 for review. Based on our discussion, at the moment, Sagas are deeply intertwined with how the application handles state with Redux. The gains from removing the pins saga is negligible compared to the complexity it would take to unravel the relationship between Redux and state management.

I did see that some of the sagas are not being used, GET_PIN_INFO_REQUEST, for example. This might be a good addition to the overall clean up of the codebase and not necessarily a performance priority before the MVP launch, imo.

[ryanfchase]

IIRC this ticket needs more work before it gets review, due to the prettier issue, yes? Moving back to In-Progress.

• You had the right idea by moving it to the review column, but please also add ready for dev lead once it needs dev lead's attention, thank you!

[ryanfchase]

Hi @efrenmarin45, thank you for your update above.

Please leave a comment with the following items:

• updated ETA
• progress from the last week
• availability for communications during the week

[ExperimentsInHonesty]

@efrenmarin45

Hi Efren, this is the template I want teams to use for their weekly updates. You can always add more info to the items below 1-4, which are the required minimum.

Instructions

1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
2. Blockers: "Difficulties or errors encountered."
3. Availability: "How much time will you have this week to work on this issue?"
4. ETA: "When do you expect this issue to be completed?"
5. Pictures (if necessary): "Add any pictures that will help illustrate what you are working on."

1. Progress:
2. Blockers:
3. Availability:
4. ETA:
5. Pictures (if necessary):

[efrenmarin45]

Progress: Need to revert changes, undo formatting, and reapply changes to force push pr.
Blockers: None
Availability: Tues & Friday
ETA: 02/21/25
Pictures: N/A

[ryanfchase]

Left my review here:

• 1865 remove pins from react redux state #1920 (review)

Since I have left another review, please provide another update for us:

Instructions

1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
2. Blockers: "Difficulties or errors encountered."
3. Availability: "How much time will you have this week to work on this issue?"
4. ETA: "When do you expect this issue to be completed?"
5. Pictures (if necessary): "Add any pictures that will help illustrate what you are working on."

1. Progress:
2. Blockers:
3. Availability:
4. ETA:
5. Pictures (if necessary):