Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Data Loading Checklist for Engineers to document loading times under various conditions #1716

Open
8 tasks
cottonchristopher opened this issue May 1, 2024 · 7 comments
Labels
Dependency An issue that includes dependencies P-feature: Map Role: Frontend React front end work Size: 1pt Can be done in 6 hours
Milestone

Comments

@cottonchristopher
Copy link
Member

cottonchristopher commented May 1, 2024

Dependency

  • Reopen when there is a need to analyze these results, or add more entries based on a new commit hash

Overview

We need a checklist for engineers to document loading times under various conditions so that we can improve load times, upload alerts about load times or create load time fillers to enhance user experience, minimize confusion.

Template

  • copy the template below
  • fill in each section

Action Items

  • measure and document load times based on selection
  • measure and document load times based on local machine vs github pages site
  • Identify various conditions that can impact data loading performance (e.g., network latency, server load, data volume
  • Document any changes made to the system or environment

### Load Time Criteria
- Platform: (local / hosted)
- Request Status: (Open / All / Closed)
- Commit Hash: (get latest commit hash)
- Operating System: (Windows / MacOs / Linux)
- Browser: (Chrome / Firefox / Safari)

### Results
- [ ] choose 3 months, 3 request types
- [ ] choose 3 months, 1 request type  
- [ ] choose 1 week, chose all requests
- [ ] choose 1 week with 2 request types

Consider splitting up work based on

Resources/Instructions

Archived Info

  • offer suggestions to update/ improve loading time (Ryan says that by completing this checklist, we can arrive at the suggestions for improvement)
  • provide recommendations for optimizing data loading performance based on test findings (same as above)
  • Provide recommendations to optimize wait experience (same as above)

@ryanfchase
Copy link
Member

Thanks @cottonchristopher -- now going to meet with @Skydodle and consider next steps for making this available for devs to pick up.

@ryanfchase
Copy link
Member

  • ETA: 6/23/24 @ 6pm PT
  • available till evening

@ryanfchase
Copy link
Member

ryanfchase commented Jun 26, 2024

Load Time Criteria

  • Platform: Hosted
  • Request Status: Open
  • Commit Hash: cfb0808
  • Operating System: Windows 11
  • Browser: Chrome, Version 126.0.6478.115 (Official Build) (64-bit)

Results

  • choose 3 months, 3 request types
    • Dataset registration & table creation (by year) time: 66 ms.
    • Data loading time: 1865 ms
    • Map loading time: 11402 ms
    • Pin load time: 39427 ms
  • choose 3 months, 1 request type
    • Dataset registration & table creation (by year) time: 26 ms
    • Data loading time: 1673 ms
    • Map loading time: 18153 ms
    • Pin load time: 57703 ms
  • choose 1 week, chose all requests
    • Dataset registration & table creation (by year) time: 8501 ms.
    • Data loading time: 177 ms
    • Map loading time: 722 ms
    • Pin load time: 10988 ms
  • choose 1 week with 2 request types
    • Dataset registration & table creation (by year) time: 34 ms.
    • Pin load time: 2942 ms

@ryanfchase
Copy link
Member

ryanfchase commented Jun 26, 2024

Load Time Criteria

  • Platform: Hosted
  • Request Status: Open (REPEAT)
  • Commit Hash: cfb0808
  • Operating System: Windows 11
  • Browser: Chrome, Version 126.0.6478.115 (Official Build) (64-bit)

Results

  • choose 3 months, 3 request types
    • Dataset registration & table creation (by year) time: 31 ms
    • Data loading time: 1855 ms
    • Map loading time: 15210 ms
    • Pin load time: 41179 ms
  • choose 3 months, 1 request type
  • choose 1 week, chose all requests
    • Dataset registration & table creation (by year) time: 15829 ms.
    • Data loading time: 459 ms
    • Map loading time: 2904 ms
    • Pin load time: 288308 ms
  • choose 1 week with 2 request types

@ryanfchase
Copy link
Member

ryanfchase commented Jun 26, 2024

Load Time Criteria

  • Platform: Hosted
  • Request Status: All
  • Commit Hash: cfb0808
  • Operating System: Windows 11
  • Browser: Chrome, Version 126.0.6478.115 (Official Build) (64-bit)

Results

  • choose 3 months, 3 request types
    • Dataset registration & table creation (by year) time: 32 ms.
    • Data loading time: 1576 ms
    • Map loading time: 12832 ms
    • Pin load time: 78614 ms
  • choose 3 months, 1 request type
  • choose 1 week, chose all requests
    • Dataset registration & table creation (by year) time: 14858 ms.
    • Data loading time: 381 ms
    • Map loading time: 3046 ms
    • Pin load time: 39322 ms
  • choose 1 week with 2 request types

@ryanfchase
Copy link
Member

ryanfchase commented Jun 26, 2024

Load Time Criteria

  • Platform: Hosted
  • Request Status: Closed
  • Commit Hash: cfb0808
  • Operating System: Windows 11
  • Browser: Chrome, Version 126.0.6478.115 (Official Build) (64-bit)

Results

  • choose 3 months, 3 request types
    • Dataset registration & table creation (by year) time: 25 ms.
    • Data loading time: 1461 ms
    • Map loading time: 9291 ms
    • Pin load time: 53692 ms
  • choose 3 months, 1 request type
  • choose 1 week, chose all requests
  • Dataset registration & table creation (by year) time: 108 ms.
  • choose 1 week with 2 request types

Notes

  • since we load data by default, it is impossible to get a first-time load on Closed requests, since Closed is just a filter on the total number of requests

@ryanfchase
Copy link
Member

Unassigning. Moving to Icebox for when we need this info / when we'd like to dig into this further

@ryanfchase ryanfchase moved this from In progress to Icebox (on hold) in P: 311: Project Board Jun 26, 2024
@ryanfchase ryanfchase added the Dependency An issue that includes dependencies label Jun 26, 2024
@ryanfchase ryanfchase removed their assignment Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency An issue that includes dependencies P-feature: Map Role: Frontend React front end work Size: 1pt Can be done in 6 hours
Projects
Status: Icebox (on hold)
Development

No branches or pull requests

3 participants