Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Neighborhood Districts #1650

Closed
Joy-Truex opened this issue Jan 18, 2024 · 10 comments
Closed

Modal Neighborhood Districts #1650

Joy-Truex opened this issue Jan 18, 2024 · 10 comments
Labels
P-feature: Map Pre-Launch Describes an issue that must be completed in order to launch ready for dev lead ready for developer lead to review the issue Role: Missing size: 0.25pt Can be done in 1.5 hours
Milestone

Comments

@Joy-Truex
Copy link
Member

Joy-Truex commented Jan 18, 2024

Overview

Design what ND filter would look like if the name is long and takes up two rows. We need to do this because names that are too long break sizing rules

Resources/Instructions

Example:
EMP CON: Empowerment Congress (don’t abbreviate)
“Arts District Little Tokyo”, “Bel Air-Beverly Crest”, etc

View the research deck for details

Design Iterations

Please move ticket between In Progress and In Review to assist PM team

Iteration 1

Link to notes: REPLACE WITH COMMENT URL

Screenshot 2024-03-27 at 4 45 41 PM


Hand Off Materials

Figma Section Name: Modal Neighborhood Districts #1650

Before Screenshot

Screenshot 2024-03-27 at 4 58 25 PM

After Screenshot (Finalized)

Screenshot 2024-03-27 at 4 59 05 PM

Designer Resources

Iteration Dropdown Copy/Paste

<details><summary>Iteration X</summary>
<p>


</p>
</details> 

Instructions for Engineering Hand Off

To Start Engineering Hand Off...

  1. Ensure all Hand Off Materials are filled in
  2. Add the "ready for dev lead" label
  3. Leave a comment saying "This ticket is ready for engineering hand off."

@ryanfchase
Copy link
Member

Hi @Joy-Truex -- thank you for making this ticket. You've done a good job of adding role, size, milestone, and project board. During our ticket workshop, we created the label draft to indicate that this ticket is still being created (e.g. more details are being added to the description, etc). I'll give a brief overview of what this ticket needs next to continue:

  1. When you feel like the ticket description is adequate, you will unassign yourself and add the ready for design lead label, and @annaseulgi will give the ticket a look-over. (ticket remains in New Issue Approval)
  2. When design lead is happy with the ticket, we can remove ready for design lead and add ready for prioritization (ticket remains in New Issue Approval)
  3. Product team will add this ticket to the Prioritized Backlog you (or any other design team member) can assign themselves and move the ticket to In Progress.

I know that's a lot! PM team is working to create a process doc, as well as communicate all this to the teams as best as possible.

@ryanfchase
Copy link
Member

ryanfchase commented Jan 18, 2024

I'm also going to add my notes on the ticket description now since it looks ready for feedback.

  1. Before the first line (Design what ND filter would look like...), please add a line of markdown text: ### Overview so we know exactly what this ticket entails
  2. Add one more sentence to your overview description that explains why this ticket exists. This helps with ticket prioritization (e.g. Design what ND filter would look like if the name is long and takes up two rows. We need to do this because names that are too long break sizing rules)
  3. Before the line that says Example:, add a line of markdown text: ### Resources/Instructions so we know that everything below is information useful to the designer
  4. Replace View the research deck for details with View the [research deck](https://docs.google.com/presentation/d/1NBMnS8_znCnYNDNNQrN2Jh5GQZhZmX56rtHME-EewBY/edit#slide=id.p1) for details

@Joy-Truex
Copy link
Member Author

wow i really botched this! thank you so much @ryanfchase , having the steps written out is so helpful for me to reference vs just trying to do it from memory!!

@Joy-Truex Joy-Truex assigned annaseulgi and unassigned Joy-Truex Jan 24, 2024
@Joy-Truex Joy-Truex added the ready for design lead ready for design lead to review the issue label Jan 24, 2024
@ryanfchase
Copy link
Member

ryanfchase commented Jan 24, 2024

You're good @Joy-Truex thank you for making those changes! This ticket is looking good now.

@annaseulgi I think this is ready for prioritization and assignment. If you're happy with it, remove the draft label and add the ready for prioritization label.

Edit: Clearing assignees until someone is actively working on this ticket, or is actively making edits to the description

@cottonchristopher cottonchristopher added the Pre-Launch Describes an issue that must be completed in order to launch label Feb 20, 2024
@Joy-Truex
Copy link
Member Author

@ryanfchase ryanfchase added ready for dev lead ready for developer lead to review the issue and removed draft ready for design lead ready for design lead to review the issue labels Mar 6, 2024
@ryanfchase ryanfchase removed the ready for dev lead ready for developer lead to review the issue label Mar 21, 2024
@Joy-Truex
Copy link
Member Author

This ticket is ready for engineering hand off.

@Joy-Truex Joy-Truex added the ready for dev lead ready for developer lead to review the issue label Mar 28, 2024
@bphan002 bphan002 self-assigned this Apr 11, 2024
@ryanfchase
Copy link
Member

FYI @bphan002 and I going to review this, and then create a dev ticket as long as we have everything we need. Most likely this will close since the work is done, thanks @Joy-Truex !

@bberhane
Copy link
Member

@ryanfchase Is this good to close?

@ryanfchase
Copy link
Member

@ryanfchase Is this good to close?

I say yes!

@bberhane
Copy link
Member

Closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Map Pre-Launch Describes an issue that must be completed in order to launch ready for dev lead ready for developer lead to review the issue Role: Missing size: 0.25pt Can be done in 1.5 hours
Projects
Status: Done (without merge)
Development

No branches or pull requests

7 participants