Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and Filters modal needs to remove abbreviation of NC names #1710

Closed
4 tasks done
ryanfchase opened this issue Apr 17, 2024 · 2 comments · Fixed by #1712
Closed
4 tasks done

Search and Filters modal needs to remove abbreviation of NC names #1710

ryanfchase opened this issue Apr 17, 2024 · 2 comments · Fixed by #1712
Assignees

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Apr 17, 2024

Overview

We need to stop abbreviating the searchable NC names in the Search and Filters modal because it is forcing users to type in the exact abbreviation, making it difficult to find those NCs

Action Items

  • Remove abbreviation of NC names when rendering them in the Search and Filters modal
  • allow those NCs to be searchable by their full names
  • if searched NC names are too long for one line in the Search and Filter modal, apply new styles for multi-line NC names
  • if selected NC names are too long for one line in the Search and Filter modal, apply new styles for multi-line selected NC name

Resources/Instructions

  • See new styles for multi-line NC names and selected multi-line NC names: Modal Neighborhood Districts #1650
  • please IGNORE changes to styles for the Search and Filters modal container
@Skydodle
Copy link
Member

@bphan002 Thanks for picking up this ticket! Just a friendly reminder to put the ticket into 'In Progress' on the Project Board after pick up =) have fun

@ryanfchase
Copy link
Member Author

@bphan002

Regarding " - please IGNORE changes to styles for the Search and Filters modal container"...

As you can see by the related design ticket, the entire Search and Filters modal has received new styles. These designs have not been approved for engineering yet -- there was a hiccup with the design system that leaked someone else's work into the hand-off designs for multi-line NC names.

As best you can, please keep the styles of the current implementation of the Search and Filters modal.

Screenshot of desired multi-line NC name styles

image

current implementation Search and Filters modal styles

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

3 participants