Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and Filters modal needs to remove abbreviation of NC names #1712

Merged

Conversation

bphan002
Copy link
Member

Fixes #1710

What changes did you make?

  1. Removed the abbreviated forms of NC names (Example: EMP to EMPOWER) in the search and filter modals.
  2. Made those NCS to be searchable by their full names
  3. Made the NC names multiline if they were too long in the search list, returned search list, and after a selection was made.
  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved
Before Screenshot of Search List (abbreviated)

Screenshot 2024-04-16 at 10 04 17 PM

After Screenshot of Search List (non abbreviated)

Screenshot 2024-04-16 at 10 03 44 PM

Before Screenshot when searching for EMPOWER

Screenshot 2024-04-16 at 10 10 29 PM

After Screenshot when searching for EMPOWER (Search works and multi-line)

Screenshot 2024-04-16 at 10 03 32 PM

Before screenshot of selected boundaries

Screenshot 2024-04-16 at 10 04 50 PM

After screenshot of selected boundaries & multi-line text

Screenshot 2024-04-16 at 10 04 29 PM

Copy link
Member

@sophia-bui sophia-bui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested for the removal of abbreviations now showing multiline full names and search list closes once selection is made. Great work, looks good to me!

Copy link
Member

@Skydodle Skydodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the abbreviated council names are all replaced with full names, worked and funcitioned as expected. Styling wrapped long council names councils names to next line. Nice work.

@bphan002 bphan002 merged commit 9a1a1e0 into hackforla:main Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search and Filters modal needs to remove abbreviation of NC names
3 participants