Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Twitter logo to 'X' #1691

Closed
3 of 4 tasks
Skydodle opened this issue Mar 1, 2024 · 3 comments · Fixed by #1698
Closed
3 of 4 tasks

Update the Twitter logo to 'X' #1691

Skydodle opened this issue Mar 1, 2024 · 3 comments · Fixed by #1698
Assignees
@drakenguyen4000
Labels
Good First Issue Good for newcomers P-feature: Footer Role: Frontend React front end work size: 0.50pt Can be done in 3 hours
Milestone
Z - Optimizations

Comments

@Skydodle
Copy link
Member

Skydodle commented Mar 1, 2024 •
edited by drakenguyen4000
Loading

Overview

We need to update the Twitter logo on the footer because the new Twitter logo is now 'X'.

Action Items

  • Check out in Resources below for all the design to engineering handoff materials you need
  • Use the light-grey 'X' logo from the Figma design file, becuase its more visible on our dark background footer in comparison to using the dark 'X' logo, but feel free to play around with both and chose at your own judgement
  • Replace the Twitter logo on our footer
  • Show before/after screenshots on your pull request

Resources/Instructions
@Skydodle Skydodle added Role: Frontend React front end work P-feature: Footer ready for dev lead ready for developer lead to review the issue size: 0.50pt Can be done in 3 hours draft labels Mar 1, 2024
@Skydodle Skydodle added this to the Z - Optimizations milestone Mar 1, 2024
@ryanfchase ryanfchase mentioned this issue Mar 1, 2024
Open
@ryanfchase ryanfchase added Good First Issue Good for newcomers and removed ready for dev lead ready for developer lead to review the issue draft labels Mar 1, 2024
@ryanfchase
Copy link
Member

This ticket is ready to be picked up, please note your ETA and Availability when moving this to In Progress

@drakenguyen4000 drakenguyen4000 self-assigned this Mar 5, 2024
@drakenguyen4000
Copy link
Member

ETA: Before 3/6/2024

@drakenguyen4000 drakenguyen4000 mentioned this issue Mar 10, 2024
Merged
4 tasks
@ryanfchase
Copy link
Member

@drakenguyen4000 ty for your work on this ticket, please move it to In Review while you are awaiting PR reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drakenguyen4000 drakenguyen4000

Labels
Good First Issue Good for newcomers P-feature: Footer Role: Frontend React front end work size: 0.50pt Can be done in 3 hours
Projects
P: 311: Project Board
Status: Done (without merge)
Milestone
Z - Optimizations
Development

Successfully merging a pull request may close this issue.

Update twitter logo to X drakenguyen4000/311-data
3 participants
@ryanfchase @drakenguyen4000 @Skydodle