Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twitter logo to X #1698

Merged

Conversation

drakenguyen4000
Copy link
Member

Fixes #1691

What changes did you make?

  • Updated the Twitter logo to 'X'.

Why did you make the changes (we will use this info to test)?

  • We wanted the logo to match Twitter's current logo.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@drakenguyen4000 drakenguyen4000 changed the title Update twitter logo to X 1691 Update twitter logo to X Mar 10, 2024
Copy link
Contributor

@funbunch funbunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drakenguyen4000 Looks good to me! Old logo is deleted and new one added.

Copy link
Member

@bphan002 bphan002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct gray X logo was used and is displaying correctly after creating a local branch.

@drakenguyen4000 drakenguyen4000 merged commit fb5b3d8 into hackforla:main Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update the Twitter logo to 'X'
3 participants