Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Closing the datepicker should cancel the ongoing selection #1836

Open
2 tasks
ryanfchase opened this issue Sep 30, 2024 · 4 comments
Open
2 tasks

Bugfix: Closing the datepicker should cancel the ongoing selection #1836

ryanfchase opened this issue Sep 30, 2024 · 4 comments
Assignees
@DorianDeptuch
Labels
Bug Something isn't working Complexity: Small P-feature: Map P-feature: Search/Filter Modal Role: Frontend React front end work size: 0.50pt Can be done in 3 hours
Milestone
05 - Bug Bash

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Sep 30, 2024 •
edited
Loading

Overview

We need to provide a way to cancel and reset the date selection so that users aren't stuck in an unspecified UX flow.

Action Items

  • Add state to track the selected dates of the datepicker that exist prior to the user selecting a new Start Date
    • e.g. initialStartDate, initialEndDate
  • Provide an event handler that restores the initial dates when the user clicks out of the datepicker dropdown, essentially canceling the datepicker flow
    • the map should not load data for the new dates, this cancellation action should be idempotent

Dev Resources

Useful Files and Components

  • Map.jsx
  • FilterMenu.jsx
  • DateSelector.jsx

Resources/Instructions
@ryanfchase ryanfchase added Role: Frontend React front end work P-feature: Map ready for dev lead ready for developer lead to review the issue size: 0.50pt Can be done in 3 hours P-feature: Search/Filter Modal labels Sep 30, 2024
@ryanfchase ryanfchase added this to the 05 - Bug Bash milestone Sep 30, 2024
@ryanfchase ryanfchase mentioned this issue Sep 30, 2024
Open
4 tasks
@ryanfchase ryanfchase added Bug Something isn't working Complexity: Small labels Sep 30, 2024
@traycn
Copy link
Member

traycn commented Oct 2, 2024

Heads up for future dev work. The state being modified in this ticket is the same state that will be worked on for this ticket: #1818 (currently in design review).

@ryanfchase
Copy link
Member Author

This ticket is ready to be picked up 👍

@DorianDeptuch DorianDeptuch self-assigned this Oct 5, 2024
@DorianDeptuch
Copy link
Member

Availability: Weekday Afternoons/Evenings
ETA: 10/13 End of Day

@ryanfchase ryanfchase removed the ready for dev lead ready for developer lead to review the issue label Oct 12, 2024
@DorianDeptuch
Copy link
Member

Updated ETA: 10/20 End of day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DorianDeptuch DorianDeptuch

Labels
Bug Something isn't working Complexity: Small P-feature: Map P-feature: Search/Filter Modal Role: Frontend React front end work size: 0.50pt Can be done in 3 hours
Projects
P: 311: Project Board
Status: In progress
Milestone
05 - Bug Bash
Development

No branches or pull requests
3 participants
@ryanfchase @traycn @DorianDeptuch