Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Hunt & Code Quality Live-Forever Ticket #1726

Open
4 tasks
Skydodle opened this issue May 12, 2024 · 10 comments
Open
4 tasks

Bug Hunt & Code Quality Live-Forever Ticket #1726

Skydodle opened this issue May 12, 2024 · 10 comments
Labels
Do Not Merge Do not merge this PR, it is likely blocked by something else Feature: Testing Good First Issue Good for newcomers Role: Frontend React front end work Size: 13pt Epic task (consider breaking into sub-tasks)
Milestone

Comments

@Skydodle
Copy link
Member

Skydodle commented May 12, 2024

Overview

The purpose of this live-forever ticket is for the assignee to document and propose fixes for bugs and code quality issues.

Dev Assignee Action Items

  • Assign yourself to this ticket
  • Report a bug / code quality issue in the comment below (see Instructions for more info)
  • Optionally propose an idea/ solution for the issue

PM/ Dev Lead Action Items

  • If any Engineering tickets created from the comments below, list them here so we know that it has been addressed

Resources/Instructions

Template

**Report Type:** Bug reporting

**Describe the issue:**
<problem>

**Proposed Solution/ Ideas:**
<solution>

**Screenshots:**

<details>
<summary>Screenshot of Issue</summary>

Use this tag to specify width/height
<img src="" height="480px"/>

Or simply paste an image from the clipboard.

</details>

---

Status
| Ticket | In-Progress? | Completed? |
|--------|--------|--------|
| 🔴  | 🔴  | 🔴  |

Bug Reporting

  • describe the issue at length, be specific about the conditions that reproduce the bug
  • include pictures or videos if possible, document it using the Details dropdown on Github Issues
  • note any relevant system info (e.g. operating system, browser, software version)
Example System Info

Desktop (please complete the following information):
OS: 13.3 (22E252)
Browser Chrome
Version 123.0.6312.86/87 / 26 March 2024

Code Quality Reporting

  • describe the issue you have with the logic or implementation of the code
  • provide the filename and which lines are affected by the quality issue
  • provide links to resources that demonstrate a similar issue or provide insight on how to address the issue
@Skydodle Skydodle added Good First Issue Good for newcomers Role: Frontend React front end work Do Not Merge Do not merge this PR, it is likely blocked by something else draft labels May 12, 2024
@Skydodle Skydodle added this to the W - Ongoing milestone May 12, 2024
@ryanfchase

This comment was marked as resolved.

@ryanfchase ryanfchase removed the draft label May 16, 2024
@Skydodle Skydodle self-assigned this May 16, 2024
@Skydodle

This comment was marked as resolved.

@Skydodle Skydodle removed their assignment May 16, 2024
@bberhane bberhane added Feature: Missing Size: Missing Size: 13pt Epic task (consider breaking into sub-tasks) and removed Size: Missing labels May 28, 2024
@ryanfchase

This comment was marked as resolved.

@aqandrew

This comment was marked as resolved.

@ryanfchase

This comment was marked as resolved.

@ryanfchase

This comment was marked as resolved.

@ryanfchase

This comment was marked as resolved.

@ryanfchase
Copy link
Member

ryanfchase commented Sep 19, 2024

Report Type: Bug reporting

Describe the issue:
When selecting a date range from the Search & Filters modal, if you close the Datepicker dropdown AFTER picking an initial date, re-opening the menu does not restart your selection (aka there's no way to un-select your start date once you've picked one).

Proposed Solution/ Ideas:
Closing the Datepicker should "reset" your selection, allowing you to start the selection over again

How to reproduce + Screenshots:

  1. Click on datepicker to show dropdown
  2. Click on a date
  3. Click out of the datepicker dropdown, closing dropdown
  4. Click on the datepicker, re-opening dropdown
  5. Observe that the first date from Step 2 is still selected, user cannot undo this selection
Screen recording of Datepicker

Status

Ticket In-Progress? Completed?
🟡 #1836 🔴 🔴

@DrAcula27
Copy link
Member

DrAcula27 commented Sep 27, 2024

Report Type: Bug reporting

Describe the issue:
When trying to deselect a NC, simply clicking outside the boundary of the selected NC does not deselect the selected NC. The user must click within the boundary of another NC to deselect the current one. This action also resets the map to the original zoom level, rather than selecting and zooming into the new NC.

Proposed Solution/Ideas:

  • When deselecting the current NC by clicking into a new NC, the map should select and zoom into the new NC.
  • When deselecting the current NC by clicking outside the boundary but not within another NC, the map should reset to its original zoom level.

Screenshots:

Screen recording of NC deselection

Status

Ticket In-Progress? Completed?
🟡 #1837 🔴 🔴

@ryanfchase
Copy link
Member

ryanfchase commented Oct 3, 2024

Report Type: Bug reporting

Describe the issue:
When using the address search to find an address...

  • if address is not within an NC, nothing happens
  • console reports: {foundNcGeoObj: undefined}

Proposed Solution/ Ideas:

  • Restore behavior prior to regression. Address search should always drop a pin, regardless if it is within an NC boundary
  • Todo: open Emergent Request for design lead

Screenshots:

Screenshot of Issue

non-la-county-geocode-failure


Status

Ticket In-Progress? Completed?
#1840 🟡 🔴 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Do not merge this PR, it is likely blocked by something else Feature: Testing Good First Issue Good for newcomers Role: Frontend React front end work Size: 13pt Epic task (consider breaking into sub-tasks)
Projects
Status: Start Here
Development

No branches or pull requests

5 participants