Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Remove invalid CSS property in AcknowledgeModal #1762

Closed
1 task done
ryanfchase opened this issue Jun 12, 2024 · 5 comments · Fixed by #1775
Closed
1 task done

Bugfix: Remove invalid CSS property in AcknowledgeModal #1762

ryanfchase opened this issue Jun 12, 2024 · 5 comments · Fixed by #1775
Assignees
@DrAcula27
Labels
Good First Issue Good for newcomers p-feature: Map associated with the MAP page for public viewing/interaction Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours
Milestone
05 - Bug Bash

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Jun 12, 2024 •
edited by DrAcula27
Loading

Overview

We can remove an invalid CSS property in the AcknowledgeModal that is currently neither hurting nor helping the component, removing it will help clear confusion around this property

More Info (optional)

Action Items

  • Remove the invalid fontWieght property from the <Typography> component in AcknowledgeModal.jsx

Resources/Instructions

Notes from the bug hunt ticket, credit @aqandrew

400 is the default font weight in our typography settings. The screenshot below shows that font-weight: 400 has been set for this element already, despite the misspelled CSS property added by sx. Therefore the fontWieght entry can be safely removed from the object passed to the sx prop.
@ryanfchase ryanfchase added Role: Frontend React front end work size: Missing missing the appropriate size that indicates the time/hours it will take to complete Feature: Missing missing the appropriate feature association, to which it's related Milestone: Missing without the associated milestone for which it is related attached draft ticket is still being created, development state Good First Issue Good for newcomers p-feature: Map associated with the MAP page for public viewing/interaction size: 0.25pt Can be done in 1.5 hours and removed size: Missing missing the appropriate size that indicates the time/hours it will take to complete Feature: Missing missing the appropriate feature association, to which it's related Milestone: Missing without the associated milestone for which it is related attached draft ticket is still being created, development state labels Jun 12, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: 311: Project Board Jun 12, 2024
@ryanfchase ryanfchase added this to the 04 - Map Page milestone Jun 12, 2024
@ryanfchase ryanfchase moved this from New Issue Approval to Prioritized Backlog (ready to be assigned) in P: 311: Project Board Jun 12, 2024
@DrAcula27 DrAcula27 self-assigned this Jun 12, 2024
@DrAcula27 DrAcula27 moved this from Prioritized Backlog (ready to be assigned) to In progress in P: 311: Project Board Jun 12, 2024
@DrAcula27
Copy link
Member

  • ETA: 17 June 2024
  • Availability: weekdays, 5pm–8pm Pacific time

@ryanfchase ryanfchase mentioned this issue Jun 12, 2024
Open
4 tasks
@DrAcula27
Copy link
Member

@ryanfchase I have made the changes in my branch to remove the offending CSS. However, when I used git status before starting my commit, I saw that there are 2 other files, that I didn't touch, have changes not staged for commit. See attached image for reference. What should I do? Go ahead and add-commit, or just ignore them?

  • I did make sure my fork of the repo is up-to-date with the upstream fork

image

@aqandrew
Copy link
Member

@DrAcula27 You can just add AcknowledgeModal.jsx to your commit and ignore the other files. 👍🏽

Those 3 other files listed are the ones I modified in #1761, so I suspect it has something to do with when you checked out my branch for that PR for review. Please feel free to DM me on Slack to get those sorted out!

@DrAcula27 DrAcula27 mentioned this issue Jun 18, 2024
Merged
4 tasks
@DrAcula27
Copy link
Member

PR has been opened for this issue at #1775

@ryanfchase
Copy link
Member Author

Leaving review with one small adjustment, thanks @DrAcula27!

https://github.com/hackforla/311-data/pull/1775/files#r1646610706

@bberhane bberhane moved this from In progress to In Review in P: 311: Project Board Jun 19, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done (without merge) in P: 311: Project Board Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrAcula27 DrAcula27

Labels
Good First Issue Good for newcomers p-feature: Map associated with the MAP page for public viewing/interaction Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours
Projects
P: 311: Project Board
Status: Done (without merge)
Milestone
05 - Bug Bash
Development

Successfully merging a pull request may close this issue.

remove invalid css, fix linter errors DrAcula27/311-data
3 participants
@ryanfchase @aqandrew @DrAcula27