Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid css, fix linter errors #1775

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

DrAcula27
Copy link
Member

Fixes #1762

What changes did you make?

  • Removed the invalid fontWieght property from the <Typography> components in AcknowledgeModal.jsx
  • Fixed some linter errors caused by white-space issues

Why did you make the changes?

  • Changes were made to clean up code and remove confusion

Checks:

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

  • No visual changes to the modal

Any questions? See the getting started guide

Copy link
Member

@aqandrew aqandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! And good job removing the font weight override on the h6 too.

Moving forward I would recommend turning off Prettier when editing existing files, until we support Prettier project-wide.

Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved after clarification on a previous comment

Copy link
Member

@Skydodle Skydodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also confirmed that the fontWeight override is not needed. Looking good, thanks for cleaning up on readability @DrAcula27 ! Feel free to merge.

@DrAcula27 DrAcula27 merged commit cbd3de8 into hackforla:main Jun 20, 2024
@DrAcula27
Copy link
Member Author

@ryanfchase I have Prettier set to not format on save unless I use Ctrl + Shift + s, so I will make sure not to enforce formatting in the future!

@DrAcula27 DrAcula27 deleted the remove-invalid-css-1762 branch June 20, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: Remove invalid CSS property in AcknowledgeModal
4 participants