Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV - De-Select NC Selection on Outside Click #1889

Closed
1 of 2 tasks
cottonchristopher opened this issue Jan 10, 2025 · 1 comment · Fixed by #1903
Closed
1 of 2 tasks

DEV - De-Select NC Selection on Outside Click #1889

cottonchristopher opened this issue Jan 10, 2025 · 1 comment · Fixed by #1903
Assignees
Labels
Milestone

Comments

@cottonchristopher
Copy link
Member

cottonchristopher commented Jan 10, 2025

Overview

We need to modify map by having clicks outside of Los Angeles to return to user to the default map zoom level.

More Info (optional)

  • Currently there is no way to deselect an NC through clicking on the map
  • A non-boundary click reset will allow for a more intuitive experience while using the map, and will allow for the user to be able to return to a baseline view of the MAP and more easily view and/or select other NC's.

Action Items

  • add an if/else statement to the onClick method in Map.jsx, that checks to see if getAllFeaturesAtPoint() returned an empty list
  • if it was an empty list, call resetMap

Resources/Instructions

Dev Resources

  • this.reset() in components > Map > Map.jsx
    • gets passed as a prop, resetMap, to the Map component, which later gets drilled down to various sub-components
  • getAllFeaturesAtPoint() in components > Map > Map.jsx
    • see onClick in the same file, this method allows us to see what Mapbox features we have clicked on.
    • specifically, we specify featureLayers, which is ['request-circles', 'nc-fills'] to indicate that we just want to know if we have clicked on a request circle, or an NC fill
@cottonchristopher
Copy link
Member Author

@cottonchristopher will review and fix; From meeting 1/9
@ryanfchase

@cottonchristopher cottonchristopher changed the title Map function and intuitiveness Map View Reset: Zoom cancellation Jan 11, 2025
@cottonchristopher cottonchristopher added the ready for dev lead ready for developer lead to review the issue label Jan 11, 2025
@ryanfchase ryanfchase assigned ryanfchase and unassigned ryanfchase Jan 11, 2025
@ryanfchase ryanfchase added size: 0.50pt Can be done in 3 hours Complexity: Small and removed size: Missing ready for dev lead ready for developer lead to review the issue draft labels Jan 14, 2025
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: 311: Project Board Jan 14, 2025
@ryanfchase ryanfchase moved this from New Issue Approval to Prioritized Backlog in P: 311: Project Board Jan 14, 2025
@ryanfchase ryanfchase changed the title Map View Reset: Zoom cancellation De-Select NC Selection on Outside Click Jan 14, 2025
@traycn traycn changed the title De-Select NC Selection on Outside Click DEV - De-Select NC Selection on Outside Click Jan 15, 2025
@bphan002 bphan002 moved this from Prioritized Backlog to In progress in P: 311: Project Board Jan 18, 2025
@bphan002 bphan002 self-assigned this Jan 18, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done (without merge) in P: 311: Project Board Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

3 participants