Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1889 de select nc selection on outside click #1903

Merged

Conversation

bphan002
Copy link
Member

Fixes #1889

What changes did you make?

  1. If someone clicks on a NC and then clicks outside of a valid NC, it resets the zoom level.

Why did you make the changes?

  1. It made the user experience better and allow for the user to have a baseline view of the map so they can easily view/select another NC.
  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

CPT2501250005-650x304

Copy link
Member

@Brandoncyu Brandoncyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if-statement now checks to see if user clicked outside of a clickable NC boundary. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEV - De-Select NC Selection on Outside Click
3 participants