-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1785 Add export button and notification dialogs #1804
Conversation
Hey @kdow I pulled the branch and it's running great on my end, just came across a minor issue with MUI. For functionality, I tested the export feature with multiple requests with each request containing a archive folder of 2 files: NeighborhoodData.csv and ServiceRequestCount.csv. It's working great! On the UI side of things, I get a console error for having the onHandler function exec in the Button element: ![]() There is an IconButton element in MUI that the error suggests we use. Links to the doc and examples below. What is your bandwidth for changing the Button element to IconButton as a potential fix for this console error? IconButton Doc & Examples: PS appreciate all the time put into this! |
a3c91ab
to
cc4d964
Compare
Thanks for catching that. It looks like it was referencing an IconButton component I created, and I just needed to move the onClick handler into it from the child Icon component. I've tested and it looks like the error went away. I've just updated the PR with the fix. |
cc4d964
to
4cce2e7
Compare
Fixed! |
LGTM thank you! |
4cce2e7
to
490e884
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested, but overall this is great work. Ty @kdow 👍
490e884
to
8776b98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes are looking good, approved. Merge when ready 👍
Fixes #1785
main
branchAny questions? See the getting started guide