Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1785 Add export button and notification dialogs #1804

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

kdow
Copy link
Member

@kdow kdow commented Aug 27, 2024

Fixes #1785

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@traycn traycn self-requested a review August 28, 2024 05:25
@traycn
Copy link
Member

traycn commented Aug 28, 2024

Hey @kdow I pulled the branch and it's running great on my end, just came across a minor issue with MUI.

For functionality, I tested the export feature with multiple requests with each request containing a archive folder of 2 files: NeighborhoodData.csv and ServiceRequestCount.csv. It's working great!

On the UI side of things, I get a console error for having the onHandler function exec in the Button element:

1785_console_error

There is an IconButton element in MUI that the error suggests we use. Links to the doc and examples below. What is your bandwidth for changing the Button element to IconButton as a potential fix for this console error?

IconButton Doc & Examples:
https://mui.com/material-ui/api/icon-button/
https://mui.com/material-ui/api/icon-button/

PS appreciate all the time put into this!

@kdow kdow force-pushed the 1785-export-button-ui branch from a3c91ab to cc4d964 Compare August 28, 2024 20:01
@kdow
Copy link
Member Author

kdow commented Aug 28, 2024

On the UI side of things, I get a console error for having the onHandler function exec in the Button element:
1785_console_error

There is an IconButton element in MUI that the error suggests we use. Links to the doc and examples below. What is your bandwidth for changing the Button element to IconButton as a potential fix for this console error?

IconButton Doc & Examples: https://mui.com/material-ui/api/icon-button/

Thanks for catching that. It looks like it was referencing an IconButton component I created, and I just needed to move the onClick handler into it from the child Icon component. I've tested and it looks like the error went away. I've just updated the PR with the fix.

@traycn
Copy link
Member

traycn commented Aug 28, 2024

Thanks! Pulled the changes and came across another small issue. The functionality works great, just another MUI issue from a type check.

1785_console_error2

Expecting that it's being thrown at the following:
components/common/ChipList/StyledChip.jsx --- line 84
label: PropTypes.string.isRequired,

@kdow kdow force-pushed the 1785-export-button-ui branch from cc4d964 to 4cce2e7 Compare August 28, 2024 21:56
@kdow
Copy link
Member Author

kdow commented Aug 28, 2024

Fixed!

@traycn
Copy link
Member

traycn commented Aug 28, 2024

LGTM thank you!

@kdow kdow force-pushed the 1785-export-button-ui branch from 4cce2e7 to 490e884 Compare August 31, 2024 18:03
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, but overall this is great work. Ty @kdow 👍

@kdow kdow force-pushed the 1785-export-button-ui branch from 490e884 to 8776b98 Compare September 2, 2024 20:48
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes are looking good, approved. Merge when ready 👍

@kdow kdow merged commit d5d5af1 into main Sep 3, 2024
@kdow kdow deleted the 1785-export-button-ui branch September 3, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Latest Export Button UI
3 participants