Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1805 fix loading spinner on mouse over popups #1812

Merged

Conversation

bphan002
Copy link
Member

@bphan002 bphan002 commented Sep 5, 2024

Fixes #1805

Info

When you hover over a pin, the previous pin information would display briefly before showing the current pin's information.

Changes Made

  • Added a redux function to clear pin info
  • Cleared Pins Info after the mouse leaves a pin

GIF Recording 2024-09-05 at 12 48 38 PM

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Requesting two minor changes.

components/Map/Map.jsx Outdated Show resolved Hide resolved
@@ -348,7 +349,7 @@ class Map extends React.Component {
.setDOMContent(this.requestDetail)
.addTo(this.map);
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picky: remove whitespace

Copy link
Member

@traycn traycn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected locally. LGTM!

Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks @bphan002 👍

@bphan002 bphan002 merged commit be99cba into hackforla:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: SR RequesetDetail loading spinner not appearing on subsequent mouse-over popups
3 participants