-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1805 fix loading spinner on mouse over popups #1812
1805 fix loading spinner on mouse over popups #1812
Conversation
…5-fix-loading-spinner-on-mouse-over-popups
…-fix-loading-spinner-on-mouse-over-popups
…://github.com/bphan002/311-data into 1805-fix-loading-spinner-on-mouse-over-popups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Requesting two minor changes.
components/Map/Map.jsx
Outdated
@@ -348,7 +349,7 @@ class Map extends React.Component { | |||
.setDOMContent(this.requestDetail) | |||
.addTo(this.map); | |||
}; | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
picky: remove whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected locally. LGTM!
…-fix-loading-spinner-on-mouse-over-popups
Co-authored-by: Ryan Chase <in.rchase@gmail.com>
…://github.com/bphan002/311-data into 1805-fix-loading-spinner-on-mouse-over-popups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks @bphan002 👍
Fixes #1805
Info
When you hover over a pin, the previous pin information would display briefly before showing the current pin's information.
Changes Made
main
branch