Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React Router to v6 and Storybook to latest #393

Closed
4 tasks done
erikguntner opened this issue Apr 6, 2022 · 0 comments · Fixed by #394
Closed
4 tasks done

Upgrade React Router to v6 and Storybook to latest #393

erikguntner opened this issue Apr 6, 2022 · 0 comments · Fixed by #394
Assignees
Labels
Complexity: Large Issue requires some research and solution is only loosely defined. dependencies Pull requests that update a dependency file Feature: Refactoring points: 1 Can be done in 4-6 hours Role: Front End

Comments

@erikguntner
Copy link
Collaborator

erikguntner commented Apr 6, 2022

Overview

Upgrade React Router to v6 and Storybook to its latest release. This issue is causing a clash in types between Storybook using React Router v6 and our use of React Router v5.

Action Items

  • Upgrade React Router to v6
  • Refactor current routes to use new API
  • Refactor Auth0 protected routes if necessary
  • Upgrade Storybook to latest release

Resources/Instructions

The issue outlining the problem: storybookjs/storybook#16837
React Router migration guide: https://reactrouter.com/docs/en/v6/upgrading/v5
Working with Auth0 and React Router v6: https://auth0.com/developers/hub/code-samples/spa/react-javascript/basic-authentication-react-router-6
Upgrading storybook: https://storybook.js.org/docs/react/configure/upgrading#gatsby-focus-wrapper

@erikguntner erikguntner added this to the 6- MVP milestone Apr 6, 2022
@erikguntner erikguntner self-assigned this Apr 6, 2022
tylerthome added a commit that referenced this issue Apr 9, 2022
Upgrade and migrate React Router to v6 and upgrade Storybook to latest release. Fixes #393
@lola3736 lola3736 added Complexity: Large Issue requires some research and solution is only loosely defined. and removed Complexity: Missing labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Issue requires some research and solution is only loosely defined. dependencies Pull requests that update a dependency file Feature: Refactoring points: 1 Can be done in 4-6 hours Role: Front End
Projects
Status: Done
2 participants