Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: Move GPS button from top rows onto map for better usability #1725

Open
2 of 3 tasks
fancyham opened this issue Jun 24, 2023 · 12 comments · May be fixed by #2360
Open
2 of 3 tasks

Map: Move GPS button from top rows onto map for better usability #1725

fancyham opened this issue Jun 24, 2023 · 12 comments · May be fixed by #2360
Assignees
Labels
dev Code Development P-Feature: Map Food seeker map view priority: COULD HAVE Ready for dev lead Issue ready for dev lead to review Role: Design UI/UX User interface / user experience design Role: Front-end Front End Developer size: 2pt The lift to complete this user story 3-4hrs skill: mapbox

Comments

@fancyham
Copy link
Collaborator

fancyham commented Jun 24, 2023

Overview

Currently, the GPS button is next to the address field which is a pretty non-standard place nowadays, and we suspect users don't know it’s there. Let's move the button onto the map itself, similar to Apple Maps and Google Maps.

Something like this:
image

Action Items

  • Devs investigate if we can move button onto map, let designers know
  • Designers specify both location and icon for GPS button, and what to do with the address bar row once the existing button goes away.
  • Devs implement

Resources/Instructions

  • I noticed that MapBox's sample maps has this — hopefully it's easy for us to do.
@fancyham fancyham added Role: Front-end Front End Developer size: 2pt The lift to complete this user story 3-4hrs P-Feature: Map Food seeker map view Ready for dev lead Issue ready for dev lead to review labels Jun 24, 2023
@fancyham
Copy link
Collaborator Author

Being addressed in UI refresh

@qiqicodes qiqicodes moved this to In Progress (actively working) in P: FOLA: Project Board May 31, 2024
@qiqicodes qiqicodes moved this from In Progress (actively working) to Icebox in P: FOLA: Project Board Jun 12, 2024
@fancyham fancyham added the dev Code Development label Aug 16, 2024
@fancyham fancyham moved this from Icebox to New Issue Approval in P: FOLA: Project Board Aug 16, 2024
@fancyham
Copy link
Collaborator Author

Related to this issue:

This option is preferred so if the GPS button can be moved onto the map (beware mobile's resizable text field!) do so.

But if this will take a while, do #2187 ASAP since it's completely missing right now from the live site.

@sumit-sharma92 sumit-sharma92 added the Missing: Milestone This issue is not part of any milestone label Sep 26, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval to ERs / Epic to make issues for in P: FOLA: Project Board Sep 27, 2024
@MuthamilselvanG MuthamilselvanG removed the Missing: Milestone This issue is not part of any milestone label Nov 7, 2024
@fancyham fancyham added the Role: Design UI/UX User interface / user experience design label Nov 28, 2024
@whitneywind whitneywind self-assigned this Jan 30, 2025
@whitneywind whitneywind moved this from Prioritized Backlog to In Progress in P: FOLA: Project Board Jan 30, 2025
@whitneywind
Copy link
Member

@fancyham Right now the new geolocate button isn't visible on mobile, because the top row filter buttons take up too much space. This causes the map to be too large, so the geolocate button is off-screen. Since the top row filter buttons' size are an issue on mobile, how does design propose we solve it? By making them smaller? Changing the text displayed on them? Once I know how to approach that problem, it will solve this issue too!

@fancyham
Copy link
Collaborator Author

fancyham commented Feb 8, 2025

Thanks -- sounds like you're confirming we can probably do it :)

Hmmm… the location on mobile… that's a good question.

Thinking out loud here: Could to at the top of the map instead, on a row below the filters and at the top-right… getting kinda crowded though. Maybe better to leave it where it is...

And on desktop, we could put it under the zoom buttons

Image

@whitneywind
Copy link
Member

@fancyham Yes, we can definitely do it! :) I actually already did it, but there are some kinks to iron out. We need to fix the map's mobile sizing problem first if we want the button to be anywhere on the right side. There doesn't seem to be an issue for that yet. For now, I can leave it at the top where it was in mobile if that works.
And for desktop, should it go under the zoom buttons or in the button right?

@whitneywind
Copy link
Member

@fancyham Should the tooltip be the same even if it's on the map?

@whitneywind whitneywind linked a pull request Feb 17, 2025 that will close this issue
@fancyham
Copy link
Collaborator Author

It'd be nice if the tooltip were a little less tall than what you shared at the last meeting, but I think it's a good idea to have one, especially as people may not understand that icon.

Could you post a screenshot of the tooltip?

I recall an old issue where we wanted to add one, so curious what text we have now:

@fancyham
Copy link
Collaborator Author

Also, please check how the tooltip works in mobile mode — iPads using mouse/trackpad will be using that soon — so we want to make sure tooltip still works

@whitneywind
Copy link
Member

@fancyham Sure, I'll update the tooltip. The mobile version of the button isn't changing with the relocate, so on mobile sizes the tooltip is the same as it is was.

This is the current tooltip size before I make adjustments to it:

Image Image

@fancyham
Copy link
Collaborator Author

fancyham commented Feb 19, 2025

Thank you. If tooltip can be less tall (on both or either mobile or desktop), that'd be great — it's looking a bit 'horsey' (big) — but can launch as-is it not easy to do. 👍

@whitneywind
Copy link
Member

Sure, that's no problem. I'll push the edits up tonight.

@fancyham
Copy link
Collaborator Author

oh, I was working on a different issue and noticed a different style tool-tip… not sure if that’s useful for you but try hovering over the ‘tab’ that I’m talking about here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Code Development P-Feature: Map Food seeker map view priority: COULD HAVE Ready for dev lead Issue ready for dev lead to review Role: Design UI/UX User interface / user experience design Role: Front-end Front End Developer size: 2pt The lift to complete this user story 3-4hrs skill: mapbox
Projects
Status: In Progress
5 participants