Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom component UniversalSelect using new library react-select… #1802

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

dipitvasdev
Copy link
Member

… to ensure consistent dropdown across platforms

Fixes #1785

What changes did you make?

  • Created custom component UniversalSelect component using react-select library
  • Designed the dropdown to look similar to how dropdown looks on windows
  • Replace existing select tags with UniversalSelect on FilterDrawer.js, ProjectPage.js, RuleStrategy.js and RuleViewContainer.js.

Why did you make the changes (we will use this info to test)?

  • The default options are controlled by OS and hence CSS changes don't work to make component consistent
  • To ensure consistency, a custom component works the same across platforms.

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied image
Visuals after changes are applied image

@entrotech entrotech merged commit 2bc0e35 into develop Aug 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Select Drop-Downs have different styling on different operating systems and browsers.
2 participants