-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and edit copy and leader cards in Communities of Practice page #1331
Comments
You can see my changes for the Engineering card and it's placement in the screenshot below. I also wanted to note that the Leadership card in the Engineering card is centered rather than left aligned in the Figma design document. Not sure if we want it to be exactly like the Figma document or if it is fine as is? |
You can see my changes adding leadership for the Project/Product Management card in the screenshot below. I wanted to note here that the description in the Figma design document for the Project Management card seems to be inconsistent with wording for the other descriptions. What I mean is that the other descriptions start with, "This group ___", but the Figma design document says something different. I'll put a screenshot of the Figma doc's description so you can see. My question is, should the old description be left as is? I have left it as for now which you can see in my screenshot. Another question I had is, are we getting rid of meeting time indicating every/every other week (see screenshots)? |
Good catch, can the leadership card please be left-aligned? Thanks!
Thank you for noticing all of these details- again great catch.. I think it's okay that the description is a little different because it is a little too repetitive that they all start exactly the same (we might change the copy in the others in the near future because they are all a little too repetitive). But this one does start a little awkwardly- can you please change the first sentence to this? "PM’s from different projects come together in this group to share effective practices, give and get mentorship, set product management standards and create guides and templates for new projects."
So glad you caught all of these inconsistencies, thank you! Yes, I believe we are removing the "every week/every other week' parentheses parts from all of them because they are all every week as far as I'm aware and according to the Events page schedule. I updated this on the Figma mobile version now as well. Let me know if anything else comes up! |
@daniellex0 Ok, so I have a few questions about the design and implementation of the website.
Screenshots
|
Hey Alex, I'm glad that you picked this one up. I was looking at the .md files yesterday (while making a template on the wiki) - would you please delete the recruiting-message from the cards that don't have "status: Seeking"? I realized that I left some in by mistake. Although they aren't shown on the website, they're probably confusing. Also, if you think it makes sense, you might change the Liquid code so that it shows that message only if status: Seeking AND recruiting-message (exists). (Currently it only checks the status.) Thanks! |
I made updates to recruiting messages and their display behavior as per @ruqpyL2's comment. |
@averdin2 Sorry about the delay Alex- yes agreed, for both sizes you mention above I think it's fine for the cards to be center-aligned and stacked! |
@akibrhast I am working on the communities of practice page and was merging some changes and ran into some conflicts. I had no problem resolving the conflicts, but changes made in this pull request: #1371, is causing some issues that I wanted to run by you. The previous build of the website before this change has the communities of practice cards ordered alphabetically starting with data-science. The current build of the website seems to have flipped the alphabetical order of the cards. I am completely making changes to programming.yml, making it now engineering.yml. When looking at the changes, the order of the cards seems to not make any sense to me now. Any idea how to fix this, and do we really need to worry about the order of the cards? I'll add a screen shot below of what my build of the cards looks like: |
Overview
We need to add and edit some copy and leader cards on the Community of Practice page to make sure the information is all up-to-date before it goes live
Action Items
Resources/Instructions
Communities of Practice Figma file (final design in pink rectangle)
Communities of Practice page
The text was updated successfully, but these errors were encountered: