Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1331 communities of practice page #1384

Conversation

averdin2
Copy link
Member

@averdin2 averdin2 commented Apr 9, 2021

Fixes #1331

Action Items

  • Make sure all text changes and additions to cards based on Figma design
  • Name change of Programming community of practice card to Engineering
  • Make sure ordering of Engineering COP card is updated
  • Make sure that recruiting message displays when status: Seeking AND recruiting-message (exists)
  • Make sure there is proper responsive behavior of leadercards within COP cards
  • Make sure viewport changes within the tablet viewport range reflect website design

Notes:

  • As per the design of the site, I had to change the display of the leadercards within
    the overall communities of practice cards to be grid instead of flex to facilitate a left
    alignment of a single leader card.
  • I also needed to make changes to certain classes' media queries to change viewport styling
    to better reflect the mobile design in the figma file for tablet views.
  • See comments in issue for more information on reasoning behind these changes.
    Link for issue: Add and edit copy and leader cards in Communities of Practice page #1331

Copy link
Member

@akibrhast akibrhast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@akibrhast akibrhast merged commit b602137 into hackforla:gh-pages Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add and edit copy and leader cards in Communities of Practice page
2 participants