Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust styling of Wins page #1336

Closed
7 tasks done
daniellex0 opened this issue Mar 28, 2021 · 4 comments · Fixed by #1386
Closed
7 tasks done

Adjust styling of Wins page #1336

daniellex0 opened this issue Mar 28, 2021 · 4 comments · Fixed by #1386
Assignees
Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Milestone

Comments

@daniellex0
Copy link
Member

daniellex0 commented Mar 28, 2021

Overview

We need to adjust the styling of the Wins page to make it more consistent with the rest of the site

Action Items

  • In mobile only: make the heading ('let's celebrate together!') 32px (instead of 38px) - use rem units
  • In mobile only: make the "Team(s)" and "Role(s)" sections the same font size- 15px - use rem units (currently one is 12px and one is 16px)
    • Try to also add a little margin between all of these lines (person's name, Teams, Roles) to give it some breathing room- maybe something like 3px?
    • Remove the margin-top from the volunteers' names on the wins cards
  • Change desktop .wins-page-contain>ul.filter-list width to 40% (instead of 46%) so that filters are less wide
  • Try to make only this header button ("Share your wins") use the properties of class ".btn-md-narrow" (smaller size) only in mobile - without affecting the mobile version of any other buttons on the site that use the same button classes (this might require adding the properties to mobile media query in .btn--wins)
  • Please add @daniellex0 as a reviewer when finished

Resources/Instructions

Wins page

@daniellex0 daniellex0 added role: front end Tasks for front end developers Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages labels Mar 28, 2021
@erikaBell erikaBell self-assigned this Apr 9, 2021
@erikaBell
Copy link
Member

erikaBell commented Apr 9, 2021

@daniellex0 , I've done the above styling. My photo below shows that a new problem arrives, with the "...see more" text. Would you like me to try to adjust that? I was looking at it, and it's set up in a way that makes it a bit tricky to work with, but since the rest of the styles were pretty easy, I don't mind trying to mess with it for a bit.

Also feel free to lmk if any of the styles I've currently added need more adjustment, i.e. the spacing between teams/roles.

New Styles Added - Wins Page Screen Shot 2021-04-09 at 1 05 10 PM
New Styles - Example 2 Screen Shot 2021-04-09 at 1 10 34 PM

@erikaBell erikaBell added the Status: Updated No blockers and update is ready for review label Apr 9, 2021
@daniellex0
Copy link
Member Author

daniellex0 commented Apr 10, 2021

Ohhh yikes, thanks for pointing this out @erikaBell ..

@jbubar has a lot of experience with dealing with the "See more" on this page so he might have some ideas..? Josh I know you have spent more time than you would like on "see more" so sorry to do this to you lol, but I thought you might have a quick fix in mind... if not, yeah Erika this might require some noodling around with CSS..

@erikaBell
Copy link
Member

@daniellex0 Oops sorry, should have stated I ended up working on it cus the challenge seemed fun, lol. So I ended up getting it together. I'll just double check my work and then make a pull request (-:

@daniellex0
Copy link
Member Author

Ah ok great! Never mind @jbubar you are saved lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants