-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Wins page styling 1336 #1386
Conversation
@erikaBell Nice work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @erikaBell ! The only change I have is:
In mobile only: make the "Team(s)" and "Role(s)" sections the same font size- 15px - use rem units (currently one is 12px and one is 16px)
To make sure these are 15px (in rem) in mobile (instead of 16px) :) - sorry I know it probably would make more sense if I wrote 16px on there lol, but trying to make these less prominent and not push the content in the card too far down/close to its bottom edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay, looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job
Fixes #1336
Additional style changes were put on "...see more" (appears during mobile view), as the changes from issue #1336 altered their placement.
Adjustments to Wins Page Styling, mobile view
Filter List Re-size, full screen view